Commit e06722a9 authored by Thorsten Blum's avatar Thorsten Blum Committed by Rafael J. Wysocki
Browse files

ACPI: APEI: Remove redundant assignments in erst_dbg_{ioctl|write}() 



Use the result of copy_from_user() directly instead of assigning it to
the local variable 'rc' and then overwriting it in erst_dbg_write() or
immediately returning from erst_dbg_ioctl().

No intentional functional changes.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarShuai Xue <xueshuai@linux.alibaba.com>
Link: https://patch.msgid.link/20250903224913.242928-2-thorsten.blum@linux.dev


[ rjw: Changelog edit ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent f83ec76b

drivers/acpi/apei/erst-dbg.c

+3 −5
Original line number Diff line number Diff line
@@ -60,9 +60,8 @@ static long erst_dbg_ioctl(struct file *f, unsigned int cmd, unsigned long arg) 


	switch (cmd) {

	case APEI_ERST_CLEAR_RECORD:

		rc = copy_from_user(&record_id, (void __user *)arg,

				    sizeof(record_id));

		if (rc)

		if (copy_from_user(&record_id, (void __user *)arg,

				   sizeof(record_id)))

			return -EFAULT;

		return erst_clear(record_id);

	case APEI_ERST_GET_RECORD_COUNT:
@@ -175,8 +174,7 @@ static ssize_t erst_dbg_write(struct file *filp, const char __user *ubuf, 
		erst_dbg_buf = p;

		erst_dbg_buf_len = usize;

	}

	rc = copy_from_user(erst_dbg_buf, ubuf, usize);

	if (rc) {

	if (copy_from_user(erst_dbg_buf, ubuf, usize)) {

		rc = -EFAULT;

		goto out;

	}