Commit e07ac2d2 authored by Justin Tee's avatar Justin Tee Committed by Martin K. Petersen
Browse files

scsi: lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss() 



In lpfc_check_nlp_post_devloss(), retaking of the ndlp lock in the if
statement is useless because the very next line unlocks. Simply return to
avoid relocking.

Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20231031191224.150862-5-justintee8345@gmail.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 1dec1311

drivers/scsi/lpfc/lpfc_hbadisc.c

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ lpfc_check_nlp_post_devloss(struct lpfc_vport *vport, 
				 "port_state = x%x\n",

				 ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp,

				 ndlp->nlp_flag, vport->port_state);

		spin_lock_irqsave(&ndlp->lock, iflags);

		return;

	}

	spin_unlock_irqrestore(&ndlp->lock, iflags);

}