Commit e12d3e16 authored by Henry Martin's avatar Henry Martin Committed by Lee Jones
Browse files

backlight: pm8941: Add NULL check in wled_configure() 



devm_kasprintf() returns NULL when memory allocation fails. Currently,
wled_configure() does not check for this case, which results in a NULL
pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: f86b7758 ("backlight: pm8941: Convert to using %pOFn instead of device_node.name")
Signed-off-by: default avatarHenry Martin <bsdhenrymartin@gmail.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: default avatar"Daniel Thompson (RISCstar)" <danielt@kernel.org>
Link: https://lore.kernel.org/r/20250401091647.22784-1-bsdhenrymartin@gmail.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent d32a0b56

drivers/video/backlight/qcom-wled.c

+4 −2
Original line number Diff line number Diff line
@@ -1406,9 +1406,11 @@ static int wled_configure(struct wled *wled) 
	wled->ctrl_addr = be32_to_cpu(*prop_addr);



	rc = of_property_read_string(dev->of_node, "label", &wled->name);

	if (rc)

	if (rc) {

		wled->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFn", dev->of_node);



		if (!wled->name)

			return -ENOMEM;

	}

	switch (wled->version) {

	case 3:

		u32_opts = wled3_opts;