Commit e1352d7e authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

modpost: refactor do_vmbus_entry() 



Optimize the size of guid_name[], as it only requires 1 additional byte
for '\0' instead of 2.

Simplify the loop by incrementing the iterator by 1 instead of 2.

Remove the unnecessary TO_NATIVE() call, as the guid is represented as
a byte stream.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Tested-by: default avatarJohn Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
parent bf36b4bf

scripts/mod/file2alias.c

+3 −5
Original line number Diff line number Diff line
@@ -812,15 +812,13 @@ static void do_virtio_entry(struct module *mod, void *symval) 
 * Each byte of the guid will be represented by two hex characters

 * in the name.

 */



static void do_vmbus_entry(struct module *mod, void *symval)

{

	int i;

	DEF_FIELD_ADDR(symval, hv_vmbus_device_id, guid);

	char guid_name[(sizeof(*guid) + 1) * 2];

	char guid_name[sizeof(*guid) * 2 + 1];



	for (i = 0; i < (sizeof(*guid) * 2); i += 2)

		sprintf(&guid_name[i], "%02x", TO_NATIVE((guid->b)[i/2]));

	for (int i = 0; i < sizeof(*guid); i++)

		sprintf(&guid_name[i * 2], "%02x", guid->b[i]);



	module_alias_printf(mod, false, "vmbus:%s", guid_name);

}