Commit e144d53c authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS/localio: nfs_close_local_fh() fix check for file closed 



If the struct nfs_file_localio is closed, its list entry will be empty,
but the nfs_uuid->files list might still contain other entries.

Acked-by: default avatarMike Snitzer <snitzer@kernel.org>
Tested-by: default avatarMike Snitzer <snitzer@kernel.org>
Reviewed-by: default avatarNeilBrown <neil@brown.name>
Fixes: 21fb4403 ("nfs_localio: protect race between nfs_uuid_put() and nfs_close_local_fh()")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent b9defd61

fs/nfs_common/nfslocalio.c

+1 −1
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ void nfs_close_local_fh(struct nfs_file_localio *nfl) 
		rcu_read_unlock();

		return;

	}

	if (list_empty(&nfs_uuid->files)) {

	if (list_empty(&nfl->list)) {

		/* nfs_uuid_put() has started closing files, wait for it

		 * to finished

		 */