Commit e1adf488 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Tzung-Bi Shih
Browse files

platform/chrome: cros_typec_switch: Don't touch struct fwnode_handle::dev 



The 'dev' field in struct fwnode is special and related to device links,
There no driver should use it for printing messages. Fix incorrect use
of private field.

Fixes: affc804c ("platform/chrome: cros_typec_switch: Add switch driver")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20260120131413.1697891-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 8f0b4cce

drivers/platform/chrome/cros_typec_switch.c

+3 −3
Original line number Diff line number Diff line
@@ -230,20 +230,20 @@ static int cros_typec_register_switches(struct cros_typec_switch_data *sdata) 


		adev = to_acpi_device_node(fwnode);

		if (!adev) {

			dev_err(fwnode->dev, "Couldn't get ACPI device handle\n");

			dev_err(dev, "Couldn't get ACPI device handle for %pfwP\n", fwnode);

			ret = -ENODEV;

			goto err_switch;

		}



		ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);

		if (ACPI_FAILURE(ret)) {

			dev_err(fwnode->dev, "_ADR wasn't evaluated\n");

			dev_err(dev, "_ADR wasn't evaluated for %pfwP\n", fwnode);

			ret = -ENODATA;

			goto err_switch;

		}



		if (index >= EC_USB_PD_MAX_PORTS) {

			dev_err(fwnode->dev, "Invalid port index number: %llu\n", index);

			dev_err(dev, "%pfwP: Invalid port index number: %llu\n", fwnode, index);

			ret = -EINVAL;

			goto err_switch;

		}