Commit e248948a authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv6: annotate data-races in rt6_probe() 



Use READ_ONCE() while reading idev->cnf.rtr_probe_interval
while its value could be changed.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fca34cc0

net/ipv6/route.c

+3 −2
Original line number Diff line number Diff line
@@ -645,14 +645,15 @@ static void rt6_probe(struct fib6_nh *fib6_nh) 
		write_lock_bh(&neigh->lock);

		if (!(neigh->nud_state & NUD_VALID) &&

		    time_after(jiffies,

			       neigh->updated + idev->cnf.rtr_probe_interval)) {

			       neigh->updated +

			       READ_ONCE(idev->cnf.rtr_probe_interval))) {

			work = kmalloc(sizeof(*work), GFP_ATOMIC);

			if (work)

				__neigh_set_probe_once(neigh);

		}

		write_unlock_bh(&neigh->lock);

	} else if (time_after(jiffies, last_probe +

				       idev->cnf.rtr_probe_interval)) {

				       READ_ONCE(idev->cnf.rtr_probe_interval))) {

		work = kmalloc(sizeof(*work), GFP_ATOMIC);

	}