Commit e27cbb60 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Guenter Roeck
Browse files

hwmon: (aspeed-g6-pwm-tach) Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarAndrew Jeffery <andrew@codeconstruct.com.au>
Link: https://lore.kernel.org/r/20240409085552.19868-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent b20b040c

drivers/hwmon/aspeed-g6-pwm-tach.c

+2 −4
Original line number Diff line number Diff line
@@ -516,13 +516,11 @@ static int aspeed_pwm_tach_probe(struct platform_device *pdev) 
	return 0;

}



static int aspeed_pwm_tach_remove(struct platform_device *pdev)

static void aspeed_pwm_tach_remove(struct platform_device *pdev)

{

	struct aspeed_pwm_tach_data *priv = platform_get_drvdata(pdev);



	reset_control_assert(priv->reset);



	return 0;

}



static const struct of_device_id aspeed_pwm_tach_match[] = {
@@ -535,7 +533,7 @@ MODULE_DEVICE_TABLE(of, aspeed_pwm_tach_match); 


static struct platform_driver aspeed_pwm_tach_driver = {

	.probe = aspeed_pwm_tach_probe,

	.remove = aspeed_pwm_tach_remove,

	.remove_new = aspeed_pwm_tach_remove,

	.driver	= {

		.name = "aspeed-g6-pwm-tach",

		.of_match_table = aspeed_pwm_tach_match,