Commit e2bfc28a authored May 11, 2021 by Guenter Roeck Committed by Sebastian Reichel Jun 03, 2021

power: supply: ab8500: Drop unnecessary NULL check after container_of



The result of container_of() operations is never NULL unless the element
is the first element of the embedded structure, which is not the case here.
The NULL check is therefore unnecessary and misleading. Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

parent 73ddad05

drivers/power/supply/ab8500_charger.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3188,9 +3188,6 @@ static int ab8500_charger_usb_notifier_call(struct notifier_block *nb,
		enum ab8500_usb_state bm_usb_state;
		unsigned mA = ((unsigned )power);

		if (!di)
		return NOTIFY_DONE;

		if (event != USB_EVENT_VBUS) {
		dev_dbg(di->dev, "not a standard host, returning\n");
		return NOTIFY_DONE;