Commit e2f152c8 authored by Julian Braha's avatar Julian Braha Committed by Jakub Kicinski
Browse files

stmmac: cleanup dead dependencies on STMMAC_PLATFORM and STMMAC_ETH in Kconfig 



There are already 'if STMMAC_ETH' and 'STMMAC_PLATFORM'
conditions wrapping these config options, making the
'depends on' statements duplicate dependencies (dead code).

I propose leaving the outer 'if STMMAC_PLATFORM...endif' and
'if STMMAC_ETH...endif' conditions, and removing the
individual 'depends on' statements.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: default avatarJulian Braha <julianbraha@gmail.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20260402145858.240231-1-julianbraha@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a9b46022

drivers/net/ethernet/stmicro/stmmac/Kconfig

+3 −6
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ if STMMAC_ETH 
config STMMAC_SELFTESTS

	bool "Support for STMMAC Selftests"

	depends on INET

	depends on STMMAC_ETH

	default n

	help

	  This adds support for STMMAC Selftests using ethtool. Enable this
@@ -29,7 +28,6 @@ config STMMAC_SELFTESTS 


config STMMAC_PLATFORM

	tristate "STMMAC Platform bus support"

	depends on STMMAC_ETH

	select MFD_SYSCON

	default y

	help
@@ -336,7 +334,6 @@ config DWMAC_IMX8 
config DWMAC_INTEL_PLAT

	tristate "Intel dwmac support"

	depends on OF && COMMON_CLK

	depends on STMMAC_ETH

	help

	  Support for ethernet controllers on Intel SoCs
@@ -371,7 +368,7 @@ config DWMAC_VISCONTI 
	help

	  Support for ethernet controller on Visconti SoCs.



endif

endif # STMMAC_PLATFORM



config STMMAC_LIBPCI

	tristate
@@ -381,7 +378,7 @@ config STMMAC_LIBPCI 
config DWMAC_INTEL

	tristate "Intel GMAC support"

	default X86

	depends on X86 && STMMAC_ETH && PCI

	depends on X86 && PCI

	depends on COMMON_CLK

	depends on ACPI

	help
@@ -420,4 +417,4 @@ config STMMAC_PCI 
	  If you have a controller with this interface, say Y or M here.



	  If unsure, say N.

endif
 
endif # STMMAC_ETH