Commit e3672a6d authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dpaa: stop ignoring TX queues past the number of CPUs 



dpaa_fq_setup() iterates through the queues allocated by dpaa_alloc_all_fqs()
and saved in &priv->dpaa_fq_list.

The allocation for FQ_TYPE_TX looks as follows:

	if (!dpaa_fq_alloc(dev, 0, dpaa_max_num_txqs(), list, FQ_TYPE_TX))
		goto fq_alloc_failed;

Thus, iterating again through FQ_TYPE_TX queues in dpaa_fq_setup() and
counting them will never yield an egress_cnt larger than the allocated
size, dpaa_max_num_txqs().

The comparison serves no purpose since it is always true; remove it.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: default avatarMadalin Bucur <madalin.bucur@oss.nxp.com>
Link: https://patch.msgid.link/20240713225336.1746343-4-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e7072750

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

+1 −5
Original line number Diff line number Diff line
@@ -971,10 +971,6 @@ static int dpaa_fq_setup(struct dpaa_priv *priv, 
		case FQ_TYPE_TX:

			dpaa_setup_egress(priv, fq, tx_port,

					  &fq_cbs->egress_ern);

			/* If we have more Tx queues than the number of cores,

			 * just ignore the extra ones.

			 */

			if (egress_cnt < dpaa_max_num_txqs())

			priv->egress_fqs[egress_cnt++] = &fq->fq_base;

			break;

		case FQ_TYPE_TX_CONF_MQ: