Commit e36a7b1e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Jonathan Corbet
Browse files

docs: submitting-patches: Clarify that removal of Acks needs explanation too 



The paragraph mentions only removal of Tested-by and Reviewed-by tags as
action needing mentioning in patch changelog, so some developers treat
it too literally.  Acks, as a weaker form of review/approval, should
rarely be removed, but if that happens it should be explained as well.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
Message-ID: <20251126081905.7684-2-krzysztof.kozlowski@oss.qualcomm.com>
parent 2006f468

Documentation/process/submitting-patches.rst

+3 −2
Original line number Diff line number Diff line
@@ -592,8 +592,9 @@ Both Tested-by and Reviewed-by tags, once received on mailing list from tester 
or reviewer, should be added by author to the applicable patches when sending

next versions.  However if the patch has changed substantially in following

version, these tags might not be applicable anymore and thus should be removed.

Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned

in the patch changelog (after the '---' separator).

Usually removal of someone's Acked-by, Tested-by or Reviewed-by tags should be

mentioned in the patch changelog with an explanation (after the '---'

separator).



A Suggested-by: tag indicates that the patch idea is suggested by the person

named and ensures credit to the person for the idea: if we diligently credit