Commit e3a682ea authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Joerg Roedel
Browse files

iommu/amd: Fix corruption when mapping large pages from 0 



If a page is mapped starting at 0 that is equal to or larger than can fit
in the current mode (number of table levels) it results in corrupting the
mapping as the following logic assumes the mode is correct for the page
size being requested.

There are two issues here, the check if the address fits within the table
uses the start address, it should use the last address to ensure that last
byte of the mapping fits within the current table mode.

The second is if the mapping is exactly the size of the full page table it
has to add another level to instead hold a single IOPTE for the large
size.

Since both corner cases require a 0 IOVA to be hit and doesn't start until
a page size of 2^48 it is unlikely to ever hit in a real system.

Reported-by: default avatarAlejandro Jimenez <alejandro.j.jimenez@oracle.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/0-v1-27ab08d646a1+29-amd_0map_jgg@nvidia.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 3f6eeada

drivers/iommu/amd/io_pgtable.c

+8 −3
Original line number Diff line number Diff line
@@ -118,6 +118,7 @@ static void free_sub_pt(u64 *root, int mode, struct list_head *freelist) 
 */

static bool increase_address_space(struct amd_io_pgtable *pgtable,

				   unsigned long address,

				   unsigned int page_size_level,

				   gfp_t gfp)

{

	struct io_pgtable_cfg *cfg = &pgtable->pgtbl.cfg;
@@ -133,7 +134,8 @@ static bool increase_address_space(struct amd_io_pgtable *pgtable, 


	spin_lock_irqsave(&domain->lock, flags);



	if (address <= PM_LEVEL_SIZE(pgtable->mode))

	if (address <= PM_LEVEL_SIZE(pgtable->mode) &&

	    pgtable->mode - 1 >= page_size_level)

		goto out;



	ret = false;
@@ -163,18 +165,21 @@ static u64 *alloc_pte(struct amd_io_pgtable *pgtable, 
		      gfp_t gfp,

		      bool *updated)

{

	unsigned long last_addr = address + (page_size - 1);

	struct io_pgtable_cfg *cfg = &pgtable->pgtbl.cfg;

	int level, end_lvl;

	u64 *pte, *page;



	BUG_ON(!is_power_of_2(page_size));



	while (address > PM_LEVEL_SIZE(pgtable->mode)) {

	while (last_addr > PM_LEVEL_SIZE(pgtable->mode) ||

	       pgtable->mode - 1 < PAGE_SIZE_LEVEL(page_size)) {

		/*

		 * Return an error if there is no memory to update the

		 * page-table.

		 */

		if (!increase_address_space(pgtable, address, gfp))

		if (!increase_address_space(pgtable, last_addr,

					    PAGE_SIZE_LEVEL(page_size), gfp))

			return NULL;

	}