Commit e421808c authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Remove useless assignments 



[WHAT & HOW]
"split_pipe" are assigned to test_pipe and then immediately are updated
to other values. The same also applies to "status" as well.

Similarly, "id", "dwb" and "unused_dpps" are assigned but the functions
immediately return, and thus they have no effects.

As a results, the assignments removed.

This fixes 5 UNUSED_VALUE issues reported by Coverity.

Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarRoman Li <roman.li@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9237c950

drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c

+0 −2
Original line number Diff line number Diff line
@@ -209,8 +209,6 @@ static bool optimize_configuration(struct dml2_context *dml2, struct dml2_wrappe 
				p->cur_display_config->output.OutputEncoder[0], p->cur_mode_support_info->DSCEnabled[0]) - 1;



			if (odms_needed <= unused_dpps) {

				unused_dpps -= odms_needed;



				if (odms_needed == 1) {

					p->new_policy->ODMUse[0] = dml_odm_use_policy_combine_2to1;

					optimization_done = true;

drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c

+0 −1
Original line number Diff line number Diff line
@@ -443,7 +443,6 @@ struct gpio *dal_gpio_create_irq( 
	case GPIO_ID_GPIO_PAD:

	break;

	default:

		id = GPIO_ID_HPD;

		ASSERT_CRITICAL(false);

		return NULL;

	}

drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c

+0 −1
Original line number Diff line number Diff line
@@ -3453,7 +3453,6 @@ static bool dcn10_can_pipe_disable_cursor(struct pipe_ctx *pipe_ctx) 
		r2 = test_pipe->plane_res.scl_data.recout;

		r2_r = r2.x + r2.width;

		r2_b = r2.y + r2.height;

		split_pipe = test_pipe;



		/**

		 * There is another half plane on same layer because of

drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c

+0 −1
Original line number Diff line number Diff line
@@ -486,7 +486,6 @@ bool dcn30_mmhubbub_warmup( 
	}

	/*following is the original: warmup each DWB's mcif buffer*/

	for (i = 0; i < num_dwb; i++) {

		dwb = dc->res_pool->dwbc[wb_info[i].dwb_pipe_inst];

		mcif_wb = dc->res_pool->mcif_wb[wb_info[i].dwb_pipe_inst];

		/*warmup is for VM mode only*/

		if (wb_info[i].mcif_buf_params.p_vmid == 0)

drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c

+0 −1
Original line number Diff line number Diff line
@@ -1068,7 +1068,6 @@ static bool dcn401_can_pipe_disable_cursor(struct pipe_ctx *pipe_ctx) 
		r2 = test_pipe->plane_res.scl_data.recout;

		r2_r = r2.x + r2.width;

		r2_b = r2.y + r2.height;

		split_pipe = test_pipe;



		/**

		 * There is another half plane on same layer because of