Commit e430c0e0 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Martin K. Petersen
Browse files

scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence() 



If ufs_qcom_power_up_sequence() fails, then it makes no sense to enable the
lane clocks and continue ufshcd_hba_enable(). So let's check the return
value of ufs_qcom_power_up_sequence().

Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20231208065902.11006-9-manivannan.sadhasivam@linaro.org


Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8775p-ride
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d1195471

drivers/ufs/host/ufs-qcom.c

+4 −1
Original line number Diff line number Diff line
@@ -417,7 +417,10 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, 


	switch (status) {

	case PRE_CHANGE:

		ufs_qcom_power_up_sequence(hba);

		err = ufs_qcom_power_up_sequence(hba);

		if (err)

			return err;



		/*

		 * The PHY PLL output is the source of tx/rx lane symbol

		 * clocks, hence, enable the lane clocks only after PHY