Unverified Commit e4476cd1 authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Robert Foss
Browse files

drm/bridge: dw-hdmi: Sync comment block with actual bus formats order 



Commit d3d6b1bf ("drm: bridge: dw_hdmi: fix preference of RGB modes
over YUV420") changed the order of the output bus formats, but missed to
update accordingly the "Possible output formats" comment section above
dw_hdmi_bridge_atomic_get_output_bus_fmts().

Fix the misleading comment block and a context related typo.

Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250204-dw-hdmi-bus-fmt-order-v2-1-d0aaeb7a697a@collabora.com
parent 0e9cb79c

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

+2 −2
Original line number Diff line number Diff line
@@ -2621,6 +2621,7 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) 
 * - MEDIA_BUS_FMT_UYYVYY12_0_5X36,

 * - MEDIA_BUS_FMT_UYYVYY10_0_5X30,

 * - MEDIA_BUS_FMT_UYYVYY8_0_5X24,

 * - MEDIA_BUS_FMT_RGB888_1X24,

 * - MEDIA_BUS_FMT_YUV16_1X48,

 * - MEDIA_BUS_FMT_RGB161616_1X48,

 * - MEDIA_BUS_FMT_UYVY12_1X24,
@@ -2631,7 +2632,6 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) 
 * - MEDIA_BUS_FMT_RGB101010_1X30,

 * - MEDIA_BUS_FMT_UYVY8_1X16,

 * - MEDIA_BUS_FMT_YUV8_1X24,

 * - MEDIA_BUS_FMT_RGB888_1X24,

 */



/* Can return a maximum of 11 possible output formats for a mode/connector */
@@ -2669,7 +2669,7 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, 
	}



	/*

	 * If the current mode enforces 4:2:0, force the output but format

	 * If the current mode enforces 4:2:0, force the output bus format

	 * to 4:2:0 and do not add the YUV422/444/RGB formats

	 */

	if (conn->ycbcr_420_allowed &&