Unverified Commit e45960c2 authored by Mateusz Guzik's avatar Mateusz Guzik Committed by Christian Brauner
Browse files

fs: unconditionally use atime_needs_update() in pick_link() 



Vast majority of the time the func returns false.

This avoids a branch to determine whether we are in RCU mode.

Signed-off-by: default avatarMateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/20250408073641.1799151-1-mjguzik@gmail.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c9b380a0

fs/namei.c

+5 −5
Original line number Diff line number Diff line
@@ -1905,13 +1905,13 @@ static const char *pick_link(struct nameidata *nd, struct path *link, 
			unlikely(link->mnt->mnt_flags & MNT_NOSYMFOLLOW))

		return ERR_PTR(-ELOOP);



	if (!(nd->flags & LOOKUP_RCU)) {

		touch_atime(&last->link);

		cond_resched();

	} else if (atime_needs_update(&last->link, inode)) {

	if (unlikely(atime_needs_update(&last->link, inode))) {

		if (nd->flags & LOOKUP_RCU) {

			if (!try_to_unlazy(nd))

				return ERR_PTR(-ECHILD);

		}

		touch_atime(&last->link);

		cond_resched();

	}



	error = security_inode_follow_link(link->dentry, inode,