Commit e4f53a4d authored by Chris Morgan's avatar Chris Morgan Committed by Neil Armstrong
Browse files

drm/panel: himax-hx8394: Drop shutdown logic 



The driver shutdown is duplicate as it calls drm_unprepare and
drm_disable which are called anyway when associated drivers are
shutdown/removed.

Signed-off-by: default avatarChris Morgan <macromorgan@hotmail.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20231204185719.569021-3-macroalpha82@gmail.com


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231204185719.569021-3-macroalpha82@gmail.com
parent 8c2c5d1d

drivers/gpu/drm/panel/panel-himax-hx8394.c

+0 −17
Original line number Diff line number Diff line
@@ -390,27 +390,11 @@ static int hx8394_probe(struct mipi_dsi_device *dsi) 
	return 0;

}



static void hx8394_shutdown(struct mipi_dsi_device *dsi)

{

	struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);

	int ret;



	ret = drm_panel_disable(&ctx->panel);

	if (ret < 0)

		dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret);



	ret = drm_panel_unprepare(&ctx->panel);

	if (ret < 0)

		dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret);

}



static void hx8394_remove(struct mipi_dsi_device *dsi)

{

	struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi);

	int ret;



	hx8394_shutdown(dsi);



	ret = mipi_dsi_detach(dsi);

	if (ret < 0)

		dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
@@ -427,7 +411,6 @@ MODULE_DEVICE_TABLE(of, hx8394_of_match); 
static struct mipi_dsi_driver hx8394_driver = {

	.probe	= hx8394_probe,

	.remove = hx8394_remove,

	.shutdown = hx8394_shutdown,

	.driver = {

		.name = DRV_NAME,

		.of_match_table = hx8394_of_match,