Commit e548ad4a authored by Roman Gushchin's avatar Roman Gushchin Committed by Andrew Morton
Browse files

mm: memcg: move charge migration code to memcontrol-v1.c 

Unlike the legacy cgroup v1 memory controller, cgroup v2 memory controller
doesn't support moving charged pages between cgroups.

It's a fairly large and complicated code which created a number of
problems in the past.  Let's move this code into memcontrol-v1.c.  It
shaves off 1k lines from memcontrol.c.  It's also another step towards
making the legacy memory controller code optionally compiled.

Link: https://lkml.kernel.org/r/20240625005906.106920-5-roman.gushchin@linux.dev


Signed-off-by: default avatarRoman Gushchin <roman.gushchin@linux.dev>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Muchun Song <muchun.song@linux.dev>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 87024f58

mm/memcontrol-v1.c

+981 −0

File changed.

Preview size limit exceeded, changes collapsed.

mm/memcontrol-v1.h

+30 −0
Original line number Diff line number Diff line
@@ -11,4 +11,34 @@ static inline void memcg1_soft_limit_reset(struct mem_cgroup *memcg) 
	WRITE_ONCE(memcg->soft_limit, PAGE_COUNTER_MAX);

}



void mem_cgroup_charge_statistics(struct mem_cgroup *memcg, int nr_pages);

void memcg_check_events(struct mem_cgroup *memcg, int nid);

void memcg_oom_recover(struct mem_cgroup *memcg);

int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask,

		     unsigned int nr_pages);



static inline int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask,

			     unsigned int nr_pages)

{

	if (mem_cgroup_is_root(memcg))

		return 0;



	return try_charge_memcg(memcg, gfp_mask, nr_pages);

}



void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n);

void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n);



bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg);

struct cgroup_taskset;

int mem_cgroup_can_attach(struct cgroup_taskset *tset);

void mem_cgroup_cancel_attach(struct cgroup_taskset *tset);

void mem_cgroup_move_task(void);



struct cftype;

u64 mem_cgroup_move_charge_read(struct cgroup_subsys_state *css,

				struct cftype *cft);

int mem_cgroup_move_charge_write(struct cgroup_subsys_state *css,

				 struct cftype *cft, u64 val);



#endif	/* __MM_MEMCONTROL_V1_H */

mm/memcontrol.c

+8 −996

File changed.

Preview size limit exceeded, changes collapsed.