Commit e5d527be authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: swnode: don't use the swnode's name as the key for GPIO lookup 



Looking up a GPIO controller by label that is the name of the software
node is wonky at best - the GPIO controller driver is free to set
a different label than the name of its firmware node. We're already being
passed a firmware node handle attached to the GPIO device to
swnode_get_gpio_device() so use it instead for a more precise lookup.

Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Fixes: e7f9ff5d ("gpiolib: add support for software nodes")
Link: https://lore.kernel.org/r/20251103-reset-gpios-swnodes-v4-4-6461800b6775@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 4a372798

drivers/gpio/gpiolib-swnode.c

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode) 
	    !strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME))

		return ERR_PTR(-ENOENT);



	gdev = gpio_device_find_by_label(gdev_node->name);

	gdev = gpio_device_find_by_fwnode(fwnode);

	return gdev ?: ERR_PTR(-EPROBE_DEFER);

}