Commit e6295d12 authored by Daniel Golle's avatar Daniel Golle Committed by Jakub Kicinski
Browse files

net: dsa: mxl862xx: add ethtool statistics support 



The MxL862xx firmware exposes per-port RMON counters through the
RMON_PORT_GET command, covering standard IEEE 802.3 MAC statistics
(unicast/multicast/broadcast packet and byte counts, collision
counters, pause frames) as well as hardware-specific counters such
as extended VLAN discard and MTU exceed events.

Add the RMON counter firmware API structures and command definitions.
Implement .get_strings, .get_sset_count, and .get_ethtool_stats for
legacy ethtool -S support. Implement .get_eth_mac_stats,
.get_eth_ctrl_stats, and .get_pause_stats for the standardized
IEEE 802.3 statistics interface.

Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/480be14d5ed51f3db7b1681b298044dbf8e87494.1775951347.git.daniel@makrotopia.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 43a2deae

drivers/net/dsa/mxl862xx/mxl862xx-api.h

+142 −0
Original line number Diff line number Diff line
@@ -1224,4 +1224,146 @@ struct mxl862xx_sys_fw_image_version { 
	__le32 iv_build_num;

} __packed;



/**

 * enum mxl862xx_port_type - Port Type

 * @MXL862XX_LOGICAL_PORT: Logical Port

 * @MXL862XX_PHYSICAL_PORT: Physical Port

 * @MXL862XX_CTP_PORT: Connectivity Termination Port (CTP)

 * @MXL862XX_BRIDGE_PORT: Bridge Port

 */

enum mxl862xx_port_type {

	MXL862XX_LOGICAL_PORT = 0,

	MXL862XX_PHYSICAL_PORT,

	MXL862XX_CTP_PORT,

	MXL862XX_BRIDGE_PORT,

};



/**

 * enum mxl862xx_rmon_port_type - RMON counter table type

 * @MXL862XX_RMON_CTP_PORT_RX: CTP RX counters

 * @MXL862XX_RMON_CTP_PORT_TX: CTP TX counters

 * @MXL862XX_RMON_BRIDGE_PORT_RX: Bridge port RX counters

 * @MXL862XX_RMON_BRIDGE_PORT_TX: Bridge port TX counters

 * @MXL862XX_RMON_CTP_PORT_PCE_BYPASS: CTP PCE bypass counters

 * @MXL862XX_RMON_TFLOW_RX: TFLOW RX counters

 * @MXL862XX_RMON_TFLOW_TX: TFLOW TX counters

 * @MXL862XX_RMON_QMAP: QMAP counters

 * @MXL862XX_RMON_METER: Meter counters

 * @MXL862XX_RMON_PMAC: PMAC counters

 */

enum mxl862xx_rmon_port_type {

	MXL862XX_RMON_CTP_PORT_RX = 0,

	MXL862XX_RMON_CTP_PORT_TX,

	MXL862XX_RMON_BRIDGE_PORT_RX,

	MXL862XX_RMON_BRIDGE_PORT_TX,

	MXL862XX_RMON_CTP_PORT_PCE_BYPASS,

	MXL862XX_RMON_TFLOW_RX,

	MXL862XX_RMON_TFLOW_TX,

	MXL862XX_RMON_QMAP = 0x0e,

	MXL862XX_RMON_METER = 0x19,

	MXL862XX_RMON_PMAC = 0x1c,

};



/**

 * struct mxl862xx_rmon_port_cnt - RMON counters for a port

 * @port_type: Port type for counter retrieval (see &enum mxl862xx_port_type)

 * @port_id: Ethernet port number (zero-based)

 * @sub_if_id_group: Sub-interface ID group

 * @pce_bypass: Separate CTP Tx counters when PCE is bypassed

 * @rx_extended_vlan_discard_pkts: Discarded at extended VLAN operation

 * @mtu_exceed_discard_pkts: Discarded due to MTU exceeded

 * @tx_under_size_good_pkts: Tx undersize (<64) packet count

 * @tx_oversize_good_pkts: Tx oversize (>1518) packet count

 * @rx_good_pkts: Received good packet count

 * @rx_unicast_pkts: Received unicast packet count

 * @rx_broadcast_pkts: Received broadcast packet count

 * @rx_multicast_pkts: Received multicast packet count

 * @rx_fcserror_pkts: Received FCS error packet count

 * @rx_under_size_good_pkts: Received undersize good packet count

 * @rx_oversize_good_pkts: Received oversize good packet count

 * @rx_under_size_error_pkts: Received undersize error packet count

 * @rx_good_pause_pkts: Received good pause packet count

 * @rx_oversize_error_pkts: Received oversize error packet count

 * @rx_align_error_pkts: Received alignment error packet count

 * @rx_filtered_pkts: Filtered packet count

 * @rx64byte_pkts: Received 64-byte packet count

 * @rx127byte_pkts: Received 65-127 byte packet count

 * @rx255byte_pkts: Received 128-255 byte packet count

 * @rx511byte_pkts: Received 256-511 byte packet count

 * @rx1023byte_pkts: Received 512-1023 byte packet count

 * @rx_max_byte_pkts: Received 1024-max byte packet count

 * @tx_good_pkts: Transmitted good packet count

 * @tx_unicast_pkts: Transmitted unicast packet count

 * @tx_broadcast_pkts: Transmitted broadcast packet count

 * @tx_multicast_pkts: Transmitted multicast packet count

 * @tx_single_coll_count: Transmit single collision count

 * @tx_mult_coll_count: Transmit multiple collision count

 * @tx_late_coll_count: Transmit late collision count

 * @tx_excess_coll_count: Transmit excessive collision count

 * @tx_coll_count: Transmit collision count

 * @tx_pause_count: Transmit pause packet count

 * @tx64byte_pkts: Transmitted 64-byte packet count

 * @tx127byte_pkts: Transmitted 65-127 byte packet count

 * @tx255byte_pkts: Transmitted 128-255 byte packet count

 * @tx511byte_pkts: Transmitted 256-511 byte packet count

 * @tx1023byte_pkts: Transmitted 512-1023 byte packet count

 * @tx_max_byte_pkts: Transmitted 1024-max byte packet count

 * @tx_dropped_pkts: Transmit dropped packet count

 * @tx_acm_dropped_pkts: Transmit ACM dropped packet count

 * @rx_dropped_pkts: Received dropped packet count

 * @rx_good_bytes: Received good byte count (64-bit)

 * @rx_bad_bytes: Received bad byte count (64-bit)

 * @tx_good_bytes: Transmitted good byte count (64-bit)

 */

struct mxl862xx_rmon_port_cnt {

	__le32 port_type; /* enum mxl862xx_port_type */

	__le16 port_id;

	__le16 sub_if_id_group;

	u8 pce_bypass;

	__le32 rx_extended_vlan_discard_pkts;

	__le32 mtu_exceed_discard_pkts;

	__le32 tx_under_size_good_pkts;

	__le32 tx_oversize_good_pkts;

	__le32 rx_good_pkts;

	__le32 rx_unicast_pkts;

	__le32 rx_broadcast_pkts;

	__le32 rx_multicast_pkts;

	__le32 rx_fcserror_pkts;

	__le32 rx_under_size_good_pkts;

	__le32 rx_oversize_good_pkts;

	__le32 rx_under_size_error_pkts;

	__le32 rx_good_pause_pkts;

	__le32 rx_oversize_error_pkts;

	__le32 rx_align_error_pkts;

	__le32 rx_filtered_pkts;

	__le32 rx64byte_pkts;

	__le32 rx127byte_pkts;

	__le32 rx255byte_pkts;

	__le32 rx511byte_pkts;

	__le32 rx1023byte_pkts;

	__le32 rx_max_byte_pkts;

	__le32 tx_good_pkts;

	__le32 tx_unicast_pkts;

	__le32 tx_broadcast_pkts;

	__le32 tx_multicast_pkts;

	__le32 tx_single_coll_count;

	__le32 tx_mult_coll_count;

	__le32 tx_late_coll_count;

	__le32 tx_excess_coll_count;

	__le32 tx_coll_count;

	__le32 tx_pause_count;

	__le32 tx64byte_pkts;

	__le32 tx127byte_pkts;

	__le32 tx255byte_pkts;

	__le32 tx511byte_pkts;

	__le32 tx1023byte_pkts;

	__le32 tx_max_byte_pkts;

	__le32 tx_dropped_pkts;

	__le32 tx_acm_dropped_pkts;

	__le32 rx_dropped_pkts;

	__le64 rx_good_bytes;

	__le64 rx_bad_bytes;

	__le64 tx_good_bytes;

} __packed;



#endif /* __MXL862XX_API_H */

drivers/net/dsa/mxl862xx/mxl862xx-cmd.h

+3 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 
#define MXL862XX_BRDGPORT_MAGIC		0x400

#define MXL862XX_CTP_MAGIC		0x500

#define MXL862XX_QOS_MAGIC		0x600

#define MXL862XX_RMON_MAGIC		0x700

#define MXL862XX_SWMAC_MAGIC		0xa00

#define MXL862XX_EXTVLAN_MAGIC		0xb00

#define MXL862XX_VLANFILTER_MAGIC	0xc00
@@ -43,6 +44,8 @@ 
#define MXL862XX_QOS_METERCFGSET	(MXL862XX_QOS_MAGIC + 0x2)

#define MXL862XX_QOS_METERALLOC		(MXL862XX_QOS_MAGIC + 0x2a)



#define MXL862XX_RMON_PORT_GET		(MXL862XX_RMON_MAGIC + 0x1)



#define MXL862XX_MAC_TABLEENTRYADD	(MXL862XX_SWMAC_MAGIC + 0x2)

#define MXL862XX_MAC_TABLEENTRYREAD	(MXL862XX_SWMAC_MAGIC + 0x3)

#define MXL862XX_MAC_TABLEENTRYQUERY	(MXL862XX_SWMAC_MAGIC + 0x4)

drivers/net/dsa/mxl862xx/mxl862xx.c

+173 −0
Original line number Diff line number Diff line
@@ -30,6 +30,38 @@ 
#define MXL862XX_API_READ_QUIET(dev, cmd, data) \

	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), true, true)



struct mxl862xx_mib_desc {

	unsigned int size;

	unsigned int offset;

	const char *name;

};



#define MIB_DESC(_size, _name, _element)					\

{									\

	.size = _size,							\

	.name = _name,							\

	.offset = offsetof(struct mxl862xx_rmon_port_cnt, _element)	\

}



/* Hardware-specific counters not covered by any standardized stats callback. */

static const struct mxl862xx_mib_desc mxl862xx_mib[] = {

	MIB_DESC(1, "TxAcmDroppedPkts", tx_acm_dropped_pkts),

	MIB_DESC(1, "RxFilteredPkts", rx_filtered_pkts),

	MIB_DESC(1, "RxExtendedVlanDiscardPkts", rx_extended_vlan_discard_pkts),

	MIB_DESC(1, "MtuExceedDiscardPkts", mtu_exceed_discard_pkts),

	MIB_DESC(2, "RxBadBytes", rx_bad_bytes),

};



static const struct ethtool_rmon_hist_range mxl862xx_rmon_ranges[] = {

	{ 0, 64 },

	{ 65, 127 },

	{ 128, 255 },

	{ 256, 511 },

	{ 512, 1023 },

	{ 1024, 10240 },

	{}

};



#define MXL862XX_SDMA_PCTRLP(p)		(0xbc0 + ((p) * 0x6))

#define MXL862XX_SDMA_PCTRL_EN		BIT(0)
@@ -1734,6 +1766,140 @@ static int mxl862xx_port_bridge_flags(struct dsa_switch *ds, int port, 
	return 0;

}



static void mxl862xx_get_strings(struct dsa_switch *ds, int port,

				 u32 stringset, u8 *data)

{

	int i;



	if (stringset != ETH_SS_STATS)

		return;



	for (i = 0; i < ARRAY_SIZE(mxl862xx_mib); i++)

		ethtool_puts(&data, mxl862xx_mib[i].name);

}



static int mxl862xx_get_sset_count(struct dsa_switch *ds, int port, int sset)

{

	if (sset != ETH_SS_STATS)

		return 0;



	return ARRAY_SIZE(mxl862xx_mib);

}



static int mxl862xx_read_rmon(struct dsa_switch *ds, int port,

			      struct mxl862xx_rmon_port_cnt *cnt)

{

	memset(cnt, 0, sizeof(*cnt));

	cnt->port_type = cpu_to_le32(MXL862XX_CTP_PORT);

	cnt->port_id = cpu_to_le16(port);



	return MXL862XX_API_READ(ds->priv, MXL862XX_RMON_PORT_GET, *cnt);

}



static void mxl862xx_get_ethtool_stats(struct dsa_switch *ds, int port,

				       u64 *data)

{

	const struct mxl862xx_mib_desc *mib;

	struct mxl862xx_rmon_port_cnt cnt;

	int ret, i;

	void *field;



	ret = mxl862xx_read_rmon(ds, port, &cnt);

	if (ret) {

		dev_err(ds->dev, "failed to read RMON stats on port %d\n", port);

		return;

	}



	for (i = 0; i < ARRAY_SIZE(mxl862xx_mib); i++) {

		mib = &mxl862xx_mib[i];

		field = (u8 *)&cnt + mib->offset;



		if (mib->size == 1)

			*data++ = le32_to_cpu(*(__le32 *)field);

		else

			*data++ = le64_to_cpu(*(__le64 *)field);

	}

}



static void mxl862xx_get_eth_mac_stats(struct dsa_switch *ds, int port,

				       struct ethtool_eth_mac_stats *mac_stats)

{

	struct mxl862xx_rmon_port_cnt cnt;



	if (mxl862xx_read_rmon(ds, port, &cnt))

		return;



	mac_stats->FramesTransmittedOK = le32_to_cpu(cnt.tx_good_pkts);

	mac_stats->SingleCollisionFrames = le32_to_cpu(cnt.tx_single_coll_count);

	mac_stats->MultipleCollisionFrames = le32_to_cpu(cnt.tx_mult_coll_count);

	mac_stats->FramesReceivedOK = le32_to_cpu(cnt.rx_good_pkts);

	mac_stats->FrameCheckSequenceErrors = le32_to_cpu(cnt.rx_fcserror_pkts);

	mac_stats->AlignmentErrors = le32_to_cpu(cnt.rx_align_error_pkts);

	mac_stats->OctetsTransmittedOK = le64_to_cpu(cnt.tx_good_bytes);

	mac_stats->LateCollisions = le32_to_cpu(cnt.tx_late_coll_count);

	mac_stats->FramesAbortedDueToXSColls = le32_to_cpu(cnt.tx_excess_coll_count);

	mac_stats->OctetsReceivedOK = le64_to_cpu(cnt.rx_good_bytes);

	mac_stats->MulticastFramesXmittedOK = le32_to_cpu(cnt.tx_multicast_pkts);

	mac_stats->BroadcastFramesXmittedOK = le32_to_cpu(cnt.tx_broadcast_pkts);

	mac_stats->MulticastFramesReceivedOK = le32_to_cpu(cnt.rx_multicast_pkts);

	mac_stats->BroadcastFramesReceivedOK = le32_to_cpu(cnt.rx_broadcast_pkts);

	mac_stats->FrameTooLongErrors = le32_to_cpu(cnt.rx_oversize_error_pkts);

}



static void mxl862xx_get_eth_ctrl_stats(struct dsa_switch *ds, int port,

					struct ethtool_eth_ctrl_stats *ctrl_stats)

{

	struct mxl862xx_rmon_port_cnt cnt;



	if (mxl862xx_read_rmon(ds, port, &cnt))

		return;



	ctrl_stats->MACControlFramesTransmitted = le32_to_cpu(cnt.tx_pause_count);

	ctrl_stats->MACControlFramesReceived = le32_to_cpu(cnt.rx_good_pause_pkts);

}



static void mxl862xx_get_pause_stats(struct dsa_switch *ds, int port,

				     struct ethtool_pause_stats *pause_stats)

{

	struct mxl862xx_rmon_port_cnt cnt;



	if (mxl862xx_read_rmon(ds, port, &cnt))

		return;



	pause_stats->tx_pause_frames = le32_to_cpu(cnt.tx_pause_count);

	pause_stats->rx_pause_frames = le32_to_cpu(cnt.rx_good_pause_pkts);

}



static void mxl862xx_get_rmon_stats(struct dsa_switch *ds, int port,

				    struct ethtool_rmon_stats *rmon_stats,

				    const struct ethtool_rmon_hist_range **ranges)

{

	struct mxl862xx_rmon_port_cnt cnt;



	if (mxl862xx_read_rmon(ds, port, &cnt))

		return;



	rmon_stats->undersize_pkts = le32_to_cpu(cnt.rx_under_size_good_pkts);

	rmon_stats->oversize_pkts = le32_to_cpu(cnt.rx_oversize_good_pkts);

	rmon_stats->fragments = le32_to_cpu(cnt.rx_under_size_error_pkts);

	rmon_stats->jabbers = le32_to_cpu(cnt.rx_oversize_error_pkts);



	rmon_stats->hist[0] = le32_to_cpu(cnt.rx64byte_pkts);

	rmon_stats->hist[1] = le32_to_cpu(cnt.rx127byte_pkts);

	rmon_stats->hist[2] = le32_to_cpu(cnt.rx255byte_pkts);

	rmon_stats->hist[3] = le32_to_cpu(cnt.rx511byte_pkts);

	rmon_stats->hist[4] = le32_to_cpu(cnt.rx1023byte_pkts);

	rmon_stats->hist[5] = le32_to_cpu(cnt.rx_max_byte_pkts);



	rmon_stats->hist_tx[0] = le32_to_cpu(cnt.tx64byte_pkts);

	rmon_stats->hist_tx[1] = le32_to_cpu(cnt.tx127byte_pkts);

	rmon_stats->hist_tx[2] = le32_to_cpu(cnt.tx255byte_pkts);

	rmon_stats->hist_tx[3] = le32_to_cpu(cnt.tx511byte_pkts);

	rmon_stats->hist_tx[4] = le32_to_cpu(cnt.tx1023byte_pkts);

	rmon_stats->hist_tx[5] = le32_to_cpu(cnt.tx_max_byte_pkts);



	*ranges = mxl862xx_rmon_ranges;

}

static const struct dsa_switch_ops mxl862xx_switch_ops = {

	.get_tag_protocol = mxl862xx_get_tag_protocol,

	.setup = mxl862xx_setup,
@@ -1758,6 +1924,13 @@ static const struct dsa_switch_ops mxl862xx_switch_ops = { 
	.port_vlan_filtering = mxl862xx_port_vlan_filtering,

	.port_vlan_add = mxl862xx_port_vlan_add,

	.port_vlan_del = mxl862xx_port_vlan_del,

	.get_strings = mxl862xx_get_strings,

	.get_sset_count = mxl862xx_get_sset_count,

	.get_ethtool_stats = mxl862xx_get_ethtool_stats,

	.get_eth_mac_stats = mxl862xx_get_eth_mac_stats,

	.get_eth_ctrl_stats = mxl862xx_get_eth_ctrl_stats,

	.get_pause_stats = mxl862xx_get_pause_stats,

	.get_rmon_stats = mxl862xx_get_rmon_stats,

};



static void mxl862xx_phylink_mac_config(struct phylink_config *config,