Commit e67b5f83 authored by Darshan Rathod's avatar Darshan Rathod Committed by Hans Verkuil
Browse files

media: uvcvideo: Fix assignment in if condition 



The function uvc_input_init() uses an assignment of the return value
of input_register_device() within the condition of an if statement.

This coding style is discouraged by the Linux kernel coding style guide
as it can be confused with a comparison and hide potential bugs.
The checkpatch.pl script flags this as an error:
"ERROR: do not use assignment in if condition"

Separate the assignment into its own statement before the conditional
check to improve code readability and adhere to the kernel's
coding standards.

Signed-off-by: default avatarDarshan Rathod <darshanrathod475@gmail.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans de Goede <hansg@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent ecba852d

drivers/media/usb/uvc/uvc_status.c

+2 −1
Original line number Diff line number Diff line
@@ -62,7 +62,8 @@ static int uvc_input_init(struct uvc_device *dev) 
	__set_bit(EV_KEY, input->evbit);

	__set_bit(KEY_CAMERA, input->keybit);



	if ((ret = input_register_device(input)) < 0)

	ret = input_register_device(input);

	if (ret < 0)

		goto error;



	dev->input = input;