Commit e6e6b692 authored by James Clark's avatar James Clark Committed by Suzuki K Poulose
Browse files

coresight: Remove extern from function declarations 



Function declarations are extern by default so remove the extra noise
and inconsistency.

Reviewed-by: default avatarLeo Yan <leo.yan@arm.com>
Reviewed-by: default avatarYeoreum Yun <yeoreum.yun@arm.com>
Signed-off-by: default avatarJames Clark <james.clark@linaro.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20250325-james-coresight-claim-tags-v4-7-dfbd3822b2e5@linaro.org
parent 48a5126b

drivers/hwtracing/coresight/coresight-priv.h

+6 −8
Original line number Diff line number Diff line
@@ -60,10 +60,8 @@ struct cs_off_attribute { 
	u32 off;

};



extern ssize_t coresight_simple_show32(struct device *_dev,

				     struct device_attribute *attr, char *buf);

extern ssize_t coresight_simple_show_pair(struct device *_dev,

				     struct device_attribute *attr, char *buf);

ssize_t coresight_simple_show32(struct device *_dev, struct device_attribute *attr, char *buf);

ssize_t coresight_simple_show_pair(struct device *_dev, struct device_attribute *attr, char *buf);



#define coresight_simple_reg32(name, offset)				\

	(&((struct cs_off_attribute[]) {				\
@@ -160,8 +158,8 @@ void coresight_path_assign_trace_id(struct coresight_path *path, 
				   enum cs_mode mode);



#if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X)

extern int etm_readl_cp14(u32 off, unsigned int *val);

extern int etm_writel_cp14(u32 off, u32 val);

int etm_readl_cp14(u32 off, unsigned int *val);

int etm_writel_cp14(u32 off, u32 val);

#else

static inline int etm_readl_cp14(u32 off, unsigned int *val) { return 0; }

static inline int etm_writel_cp14(u32 off, u32 val) { return 0; }
@@ -172,8 +170,8 @@ struct cti_assoc_op { 
	void (*remove)(struct coresight_device *csdev);

};



extern void coresight_set_cti_ops(const struct cti_assoc_op *cti_op);

extern void coresight_remove_cti_ops(void);

void coresight_set_cti_ops(const struct cti_assoc_op *cti_op);

void coresight_remove_cti_ops(void);



/*

 * Macros and inline functions to handle CoreSight UCI data and driver

include/linux/coresight.h

+17 −18
Original line number Diff line number Diff line
@@ -671,28 +671,27 @@ static inline void coresight_set_mode(struct coresight_device *csdev, 
	local_set(&csdev->mode, new_mode);

}



extern struct coresight_device *

coresight_register(struct coresight_desc *desc);

extern void coresight_unregister(struct coresight_device *csdev);

extern int coresight_enable_sysfs(struct coresight_device *csdev);

extern void coresight_disable_sysfs(struct coresight_device *csdev);

extern int coresight_timeout(struct csdev_access *csa, u32 offset,

			     int position, int value);

struct coresight_device *coresight_register(struct coresight_desc *desc);

void coresight_unregister(struct coresight_device *csdev);

int coresight_enable_sysfs(struct coresight_device *csdev);

void coresight_disable_sysfs(struct coresight_device *csdev);

int coresight_timeout(struct csdev_access *csa, u32 offset, int position, int value);

typedef void (*coresight_timeout_cb_t) (struct csdev_access *, u32, int, int);

extern int coresight_timeout_action(struct csdev_access *csa, u32 offset,

					int position, int value,

int coresight_timeout_action(struct csdev_access *csa, u32 offset, int position, int value,

			     coresight_timeout_cb_t cb);

int coresight_claim_device(struct coresight_device *csdev);

int coresight_claim_device_unlocked(struct coresight_device *csdev);



extern int coresight_claim_device(struct coresight_device *csdev);

extern int coresight_claim_device_unlocked(struct coresight_device *csdev);

int coresight_claim_device(struct coresight_device *csdev);

int coresight_claim_device_unlocked(struct coresight_device *csdev);

void coresight_clear_self_claim_tag(struct csdev_access *csa);

void coresight_clear_self_claim_tag_unlocked(struct csdev_access *csa);

extern void coresight_disclaim_device(struct coresight_device *csdev);

extern void coresight_disclaim_device_unlocked(struct coresight_device *csdev);

extern char *coresight_alloc_device_name(struct coresight_dev_list *devs,

void coresight_disclaim_device(struct coresight_device *csdev);

void coresight_disclaim_device_unlocked(struct coresight_device *csdev);

char *coresight_alloc_device_name(struct coresight_dev_list *devs,

					 struct device *dev);



extern bool coresight_loses_context_with_cpu(struct device *dev);

bool coresight_loses_context_with_cpu(struct device *dev);



u32 coresight_relaxed_read32(struct coresight_device *csdev, u32 offset);

u32 coresight_read32(struct coresight_device *csdev, u32 offset);
@@ -705,8 +704,8 @@ void coresight_relaxed_write64(struct coresight_device *csdev, 
			       u64 val, u32 offset);

void coresight_write64(struct coresight_device *csdev, u64 val, u32 offset);



extern int coresight_get_cpu(struct device *dev);

extern int coresight_get_static_trace_id(struct device *dev, u32 *id);

int coresight_get_cpu(struct device *dev);

int coresight_get_static_trace_id(struct device *dev, u32 *id);



struct coresight_platform_data *coresight_get_platform_data(struct device *dev);

struct coresight_connection *