Commit e7e441a4 authored by Paul Barker's avatar Paul Barker Committed by Jakub Kicinski
Browse files

net: ravb: Fix max TX frame size for RZ/V2M 



When tx_max_frame_size was added to struct ravb_hw_info, no value was
set in ravb_rzv2m_hw_info so the default value of zero was used.

The maximum MTU is set by subtracting from tx_max_frame_size to allow
space for headers and frame checksums. As ndev->max_mtu is unsigned,
this subtraction wraps around leading to a ridiculously large positive
value that is obviously incorrect.

Before tx_max_frame_size was introduced, the maximum MTU was based on
rx_max_frame_size. So, we can restore the correct maximum MTU by copying
the rx_max_frame_size value into tx_max_frame_size for RZ/V2M.

Fixes: 1d638642 ("net: ravb: Fix maximum TX frame size for GbEth devices")
Signed-off-by: default avatarPaul Barker <paul.barker.ct@bp.renesas.com>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://patch.msgid.link/20250109113706.1409149-1-paul.barker.ct@bp.renesas.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent eaeea502

drivers/net/ethernet/renesas/ravb_main.c

+1 −0
Original line number Diff line number Diff line
@@ -2763,6 +2763,7 @@ static const struct ravb_hw_info ravb_rzv2m_hw_info = { 
	.net_features = NETIF_F_RXCSUM,

	.stats_len = ARRAY_SIZE(ravb_gstrings_stats),

	.tccr_mask = TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | TCCR_TSRQ3,

	.tx_max_frame_size = SZ_2K,

	.rx_max_frame_size = SZ_2K,

	.rx_buffer_size = SZ_2K +

			  SKB_DATA_ALIGN(sizeof(struct skb_shared_info)),