Commit e7ea5f5b authored by David Thompson's avatar David Thompson Committed by Jakub Kicinski
Browse files

mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available 



The message "Error getting PHY irq. Use polling instead"
is emitted when the mlxbf_gige driver is loaded by the
kernel before the associated gpio-mlxbf driver, and thus
the call to get the PHY IRQ fails since it is not yet
available. The driver probe() must return -EPROBE_DEFER
if acpi_dev_gpio_irq_get_by() returns the same.

Fixes: 6c2a6ddc ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")
Signed-off-by: default avatarDavid Thompson <davthompson@nvidia.com>
Reviewed-by: default avatarAsmaa Mnebhi <asmaa@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250618135902.346-1-davthompson@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 78bd03ee

drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c

+4 −2
Original line number Diff line number Diff line
@@ -447,8 +447,10 @@ static int mlxbf_gige_probe(struct platform_device *pdev) 
	priv->llu_plu_irq = platform_get_irq(pdev, MLXBF_GIGE_LLU_PLU_INTR_IDX);



	phy_irq = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(&pdev->dev), "phy", 0);

	if (phy_irq < 0) {

		dev_err(&pdev->dev, "Error getting PHY irq. Use polling instead");

	if (phy_irq == -EPROBE_DEFER) {

		err = -EPROBE_DEFER;

		goto out;

	} else if (phy_irq < 0) {

		phy_irq = PHY_POLL;

	}