Commit e82bf757 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Thomas Gleixner
Browse files

selftests: vDSO: Drop vdso_test_clock_getres 



vdso_test_abi provides the exact same functionality, properly uses
kselftest.h and explicitly calls into the vDSO without relying on the libc.

Drop the pointless testcase.

Signed-off-by: default avatarThomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250812-vdso-tests-fixes-v2-8-90f499dd35f8@linutronix.de
parent 7262aa78

tools/testing/selftests/vDSO/.gitignore

+0 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

vdso_test

vdso_test_abi

vdso_test_clock_getres

vdso_test_correctness

vdso_test_gettimeofday

vdso_test_getcpu

tools/testing/selftests/vDSO/Makefile

+0 −2
Original line number Diff line number Diff line
@@ -4,7 +4,6 @@ include ../../../scripts/Makefile.arch 
TEST_GEN_PROGS := vdso_test_gettimeofday

TEST_GEN_PROGS += vdso_test_getcpu

TEST_GEN_PROGS += vdso_test_abi

TEST_GEN_PROGS += vdso_test_clock_getres

ifeq ($(ARCH),$(filter $(ARCH),x86 x86_64))

TEST_GEN_PROGS += vdso_standalone_test_x86

endif
@@ -29,7 +28,6 @@ CFLAGS_NOLIBC := -nostdlib -nostdinc -ffreestanding -fno-asynchronous-unwind-tab 
$(OUTPUT)/vdso_test_gettimeofday: parse_vdso.c vdso_test_gettimeofday.c

$(OUTPUT)/vdso_test_getcpu: parse_vdso.c vdso_test_getcpu.c

$(OUTPUT)/vdso_test_abi: parse_vdso.c vdso_test_abi.c

$(OUTPUT)/vdso_test_clock_getres: vdso_test_clock_getres.c



$(OUTPUT)/vdso_standalone_test_x86: vdso_standalone_test_x86.c parse_vdso.c | headers

$(OUTPUT)/vdso_standalone_test_x86: CFLAGS:=$(CFLAGS_NOLIBC) $(CFLAGS)

tools/testing/selftests/vDSO/vdso_test_clock_getres.c

deleted100644 → 0
+0 −123
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note

/*

 * vdso_clock_getres.c: Sample code to test clock_getres.

 * Copyright (c) 2019 Arm Ltd.

 *

 * Compile with:

 * gcc -std=gnu99 vdso_clock_getres.c

 *

 * Tested on ARM, ARM64, MIPS32, x86 (32-bit and 64-bit),

 * Power (32-bit and 64-bit), S390x (32-bit and 64-bit).

 * Might work on other architectures.

 */



#define _GNU_SOURCE

#include <elf.h>

#include <fcntl.h>

#include <stdint.h>

#include <stdio.h>

#include <stdlib.h>

#include <time.h>

#include <sys/auxv.h>

#include <sys/mman.h>

#include <sys/time.h>

#include <unistd.h>

#include <sys/syscall.h>



#include "../kselftest.h"



static long syscall_clock_getres(clockid_t _clkid, struct timespec *_ts)

{

	long ret;



	ret = syscall(SYS_clock_getres, _clkid, _ts);



	return ret;

}



const char *vdso_clock_name[12] = {

	"CLOCK_REALTIME",

	"CLOCK_MONOTONIC",

	"CLOCK_PROCESS_CPUTIME_ID",

	"CLOCK_THREAD_CPUTIME_ID",

	"CLOCK_MONOTONIC_RAW",

	"CLOCK_REALTIME_COARSE",

	"CLOCK_MONOTONIC_COARSE",

	"CLOCK_BOOTTIME",

	"CLOCK_REALTIME_ALARM",

	"CLOCK_BOOTTIME_ALARM",

	"CLOCK_SGI_CYCLE",

	"CLOCK_TAI",

};



/*

 * This function calls clock_getres in vdso and by system call

 * with different values for clock_id.

 *

 * Example of output:

 *

 * clock_id: CLOCK_REALTIME [PASS]

 * clock_id: CLOCK_BOOTTIME [PASS]

 * clock_id: CLOCK_TAI [PASS]

 * clock_id: CLOCK_REALTIME_COARSE [PASS]

 * clock_id: CLOCK_MONOTONIC [PASS]

 * clock_id: CLOCK_MONOTONIC_RAW [PASS]

 * clock_id: CLOCK_MONOTONIC_COARSE [PASS]

 */

static inline int vdso_test_clock(unsigned int clock_id)

{

	struct timespec x, y;



	printf("clock_id: %s", vdso_clock_name[clock_id]);

	clock_getres(clock_id, &x);

	syscall_clock_getres(clock_id, &y);



	if ((x.tv_sec != y.tv_sec) || (x.tv_nsec != y.tv_nsec)) {

		printf(" [FAIL]\n");

		return KSFT_FAIL;

	}



	printf(" [PASS]\n");

	return KSFT_PASS;

}



int main(int argc, char **argv)

{

	int ret = 0;



#if _POSIX_TIMERS > 0



#ifdef CLOCK_REALTIME

	ret += vdso_test_clock(CLOCK_REALTIME);

#endif



#ifdef CLOCK_BOOTTIME

	ret += vdso_test_clock(CLOCK_BOOTTIME);

#endif



#ifdef CLOCK_TAI

	ret += vdso_test_clock(CLOCK_TAI);

#endif



#ifdef CLOCK_REALTIME_COARSE

	ret += vdso_test_clock(CLOCK_REALTIME_COARSE);

#endif



#ifdef CLOCK_MONOTONIC

	ret += vdso_test_clock(CLOCK_MONOTONIC);

#endif



#ifdef CLOCK_MONOTONIC_RAW

	ret += vdso_test_clock(CLOCK_MONOTONIC_RAW);

#endif



#ifdef CLOCK_MONOTONIC_COARSE

	ret += vdso_test_clock(CLOCK_MONOTONIC_COARSE);

#endif



#endif

	if (ret > 0)

		return KSFT_FAIL;



	return KSFT_PASS;

}