Commit e8341668 authored by Luis Felipe Hernandez's avatar Luis Felipe Hernandez Committed by Madhavan Srinivasan
Browse files

macintosh: declare ctl_table as const 



Since commit 7abc9b53 ("sysctl: allow registration of const struct
ctl_table"), the sysctl registration API allows struct ctl_table variables
to be placed into read-only memory.

mac_hid_files is registered as a sysctl table and should be treated as
read-only. By declaring the mac_hid_files structure as const, we ensure
that it cannot be accidentally modified. This change improves safety.

Suggested-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Suggested-by: default avatarRicardo B. Marliere <rbm@suse.com>
Reviewed-by: default avatarRicardo B. Marliere <rbm@suse.com>
Signed-off-by: default avatarLuis Felipe Hernandez <luis.hernandez093@gmail.com>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20241217-constify_ctl_table-v1-1-402ebceaeb8e@gmail.com
parent 65f50383

drivers/macintosh/mac_hid.c

+1 −1
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ static int mac_hid_toggle_emumouse(const struct ctl_table *table, int write, 
}



/* file(s) in /proc/sys/dev/mac_hid */

static struct ctl_table mac_hid_files[] = {

static const struct ctl_table mac_hid_files[] = {

	{

		.procname	= "mouse_button_emulation",

		.data		= &mouse_emulate_buttons,