Commit e8784765 authored by Xiu Jianfeng's avatar Xiu Jianfeng Committed by Tejun Heo
Browse files

cgroup/cpuset: Avoid clearing CS_SCHED_LOAD_BALANCE twice 



In cpuset_css_online(), CS_SCHED_LOAD_BALANCE will be cleared twice,
the former one in the is_in_v2_mode() case could be removed because
is_in_v2_mode() can be true for cgroup v1 if the "cpuset_v2_mode"
mount option is specified, that balance flag change isn't appropriate
for this particular case.

Signed-off-by: default avatarXiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 8996f93f

kernel/cgroup/cpuset.c

+0 −5
Original line number Diff line number Diff line
@@ -4052,11 +4052,6 @@ static int cpuset_css_online(struct cgroup_subsys_state *css) 
		cs->effective_mems = parent->effective_mems;

		cs->use_parent_ecpus = true;

		parent->child_ecpus_count++;

		/*

		 * Clear CS_SCHED_LOAD_BALANCE if parent is isolated

		 */

		if (!is_sched_load_balance(parent))

			clear_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);

	}



	/*