Commit e8ac8974 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Paolo Abeni
Browse files

net: bcmasp: Simplify with scoped for each OF child loop 



Use scoped for_each_available_child_of_node_scoped() when
iterating over device nodes to make code a bit simpler.

Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: default avatarJustin Chen <justin.chen@broadcom.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent f834d572

drivers/net/ethernet/broadcom/asp2/bcmasp.c

+2 −3
Original line number Diff line number Diff line
@@ -1300,9 +1300,9 @@ static void bcmasp_remove_intfs(struct bcmasp_priv *priv) 


static int bcmasp_probe(struct platform_device *pdev)

{

	struct device_node *ports_node, *intf_node;

	const struct bcmasp_plat_data *pdata;

	struct device *dev = &pdev->dev;

	struct device_node *ports_node;

	struct bcmasp_priv *priv;

	struct bcmasp_intf *intf;

	int ret = 0, count = 0;
@@ -1374,12 +1374,11 @@ static int bcmasp_probe(struct platform_device *pdev) 
	}



	i = 0;

	for_each_available_child_of_node(ports_node, intf_node) {

	for_each_available_child_of_node_scoped(ports_node, intf_node) {

		intf = bcmasp_interface_create(priv, intf_node, i);

		if (!intf) {

			dev_err(dev, "Cannot create eth interface %d\n", i);

			bcmasp_remove_intfs(priv);

			of_node_put(intf_node);

			ret = -ENOMEM;

			goto of_put_exit;

		}