Commit e93bd172 authored by Trevor Gamblin's avatar Trevor Gamblin Committed by Jonathan Cameron
Browse files

iio: magnetometer: ak8974: make use of regmap_set_bits() 



Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Suggested-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: default avatarTrevor Gamblin <tgamblin@baylibre.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-33-88d1338c4cca@baylibre.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent df4083d3

drivers/iio/magnetometer/ak8974.c

+2 −8
Original line number Diff line number Diff line
@@ -327,10 +327,7 @@ static int ak8974_trigmeas(struct ak8974 *ak8974) 
	}



	/* Force a measurement */

	return regmap_update_bits(ak8974->map,

				  AK8974_CTRL3,

				  AK8974_CTRL3_FORCE,

				  AK8974_CTRL3_FORCE);

	return regmap_set_bits(ak8974->map, AK8974_CTRL3, AK8974_CTRL3_FORCE);

}



static int ak8974_await_drdy(struct ak8974 *ak8974)
@@ -438,10 +435,7 @@ static int ak8974_selftest(struct ak8974 *ak8974) 
	}



	/* Trigger self-test */

	ret = regmap_update_bits(ak8974->map,

			AK8974_CTRL3,

			AK8974_CTRL3_SELFTEST,

			AK8974_CTRL3_SELFTEST);

	ret = regmap_set_bits(ak8974->map, AK8974_CTRL3, AK8974_CTRL3_SELFTEST);

	if (ret) {

		dev_err(dev, "could not write CTRL3\n");

		return ret;