Commit ea0b0bce authored by Kees Cook's avatar Kees Cook Committed by Luis Chamberlain
Browse files

module: Annotate struct module_notes_attrs with __counted_by 

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct module_notes_attrs.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci



Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent fd06da77

kernel/module/sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static void remove_sect_attrs(struct module *mod) 
struct module_notes_attrs {

	struct kobject *dir;

	unsigned int notes;

	struct bin_attribute attrs[];

	struct bin_attribute attrs[] __counted_by(notes);

};



static ssize_t module_notes_read(struct file *filp, struct kobject *kobj,