Commit ea41bb51 authored Oct 04, 2023 by Ingo Molnar

sched/core: Update stale comment in try_to_wake_up()



The following commit:

  9b3c4ab3 ("sched,rcu: Rework try_invoke_on_locked_down_task()")

... renamed try_invoke_on_locked_down_task() to task_call_func(),
but forgot to update the comment in try_to_wake_up().

But it turns out that the smp_rmb() doesn't live in task_call_func()
either, it was moved to __task_needs_rq_lock() in:

  91dabf33 ("sched: Fix race in task_call_func()")

Fix that now.

Also fix the s/smb/smp typo while at it.

Reported-by: Zhang Qiao <zhangqiao22@huawei.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230731085759.11443-1-zhangqiao22@huawei.com

parent 8db30574

kernel/sched/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4237,7 +4237,7 @@ int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
		* Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
		* __schedule(). See the comment for smp_mb__after_spinlock().
		*
		* A similar smb_rmb() lives in try_invoke_on_locked_down_task().
		* A similar smp_rmb() lives in __task_needs_rq_lock().
		*/
		smp_rmb();
		if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags))