Unverified Commit ea8f6b29 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: soc-topology: cleanup cppcheck warning at soc_tplg_kcontrol_elems_load() 



This patch cleanups below cppcheck warning.

sound/soc/soc-topology.c:1038:31: style: The scope of the variable 'control_hdr' can be reduced. [variableScope]
 struct snd_soc_tplg_ctl_hdr *control_hdr;
                              ^

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87o8agwfkv.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e9aa139f

sound/soc/soc-topology.c

+1 −3
Original line number Diff line number Diff line
@@ -1035,7 +1035,6 @@ static int soc_tplg_denum_create(struct soc_tplg *tplg, unsigned int count, 
static int soc_tplg_kcontrol_elems_load(struct soc_tplg *tplg,

	struct snd_soc_tplg_hdr *hdr)

{

	struct snd_soc_tplg_ctl_hdr *control_hdr;

	int ret;

	int i;
@@ -1043,8 +1042,7 @@ static int soc_tplg_kcontrol_elems_load(struct soc_tplg *tplg, 
		soc_tplg_get_offset(tplg));



	for (i = 0; i < le32_to_cpu(hdr->count); i++) {



		control_hdr = (struct snd_soc_tplg_ctl_hdr *)tplg->pos;

		struct snd_soc_tplg_ctl_hdr *control_hdr = (struct snd_soc_tplg_ctl_hdr *)tplg->pos;



		if (le32_to_cpu(control_hdr->size) != sizeof(*control_hdr)) {

			dev_err(tplg->dev, "ASoC: invalid control size\n");