Commit eab03963 authored by Wentao Liang's avatar Wentao Liang Committed by Jakub Kicinski
Browse files

net/mlx5: handle errors in mlx5_chains_create_table() 



In mlx5_chains_create_table(), the return value of mlx5_get_fdb_sub_ns()
and mlx5_get_flow_namespace() must be checked to prevent NULL pointer
dereferences. If either function fails, the function should log error
message with mlx5_core_warn() and return error pointer.

Fixes: 39ac237c ("net/mlx5: E-Switch, Refactor chains and priorities")
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250307021820.2646-1-vulab@iscas.ac.cn
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 505ead7a

drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c

+5 −0
Original line number Diff line number Diff line
@@ -196,6 +196,11 @@ mlx5_chains_create_table(struct mlx5_fs_chains *chains, 
		ns = mlx5_get_flow_namespace(chains->dev, chains->ns);

	}



	if (!ns) {

		mlx5_core_warn(chains->dev, "Failed to get flow namespace\n");

		return ERR_PTR(-EOPNOTSUPP);

	}



	ft_attr.autogroup.num_reserved_entries = 2;

	ft_attr.autogroup.max_num_groups = chains->group_num;

	ft = mlx5_create_auto_grouped_flow_table(ns, &ft_attr);