Commit eab0dce1 authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Martin K. Petersen
Browse files

scsi: ufs: ufshcd-pltfrm: Use of_property_count_u32_elems() to get property length 



Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property() and
similar functions. of_get_property() leaks the DT property data pointer
which is a problem for dynamically allocated nodes which may be freed.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240808170704.1438658-1-robh@kernel.org


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent fd9cb961

drivers/ufs/host/ufshcd-pltfrm.c

+2 −6
Original line number Diff line number Diff line
@@ -31,7 +31,6 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba) 
	const char *name;

	u32 *clkfreq = NULL;

	struct ufs_clk_info *clki;

	int len = 0;

	size_t sz = 0;



	if (!np)
@@ -50,15 +49,12 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba) 
	if (cnt <= 0)

		goto out;



	if (!of_get_property(np, "freq-table-hz", &len)) {

	sz = of_property_count_u32_elems(np, "freq-table-hz");

	if (sz <= 0) {

		dev_info(dev, "freq-table-hz property not specified\n");

		goto out;

	}



	if (len <= 0)

		goto out;



	sz = len / sizeof(*clkfreq);

	if (sz != 2 * cnt) {

		dev_err(dev, "%s len mismatch\n", "freq-table-hz");

		ret = -EINVAL;