Commit ebae1028 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Chuck Lever
Browse files

nfsd: Mark variable __maybe_unused to avoid W=1 build break 

Clang is not happy about set but (in some cases) unused variable:

fs/nfsd/export.c:1027:17: error: variable 'inode' set but not used [-Werror,-Wunused-but-set-variable]

since it's used as a parameter to dprintk() which might be configured
a no-op. To avoid uglifying code with the specific ifdeffery just mark
the variable __maybe_unused.

The commit [1], which introduced this behaviour, is quite old and hence
the Fixes tag points to the first of the Git era.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=0431923fb7a1

 [1]
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent d1bea0ce

fs/nfsd/export.c

+1 −1
Original line number Diff line number Diff line
@@ -1024,7 +1024,7 @@ exp_rootfh(struct net *net, struct auth_domain *clp, char *name, 
{

	struct svc_export	*exp;

	struct path		path;

	struct inode		*inode;

	struct inode		*inode __maybe_unused;

	struct svc_fh		fh;

	int			err;

	struct nfsd_net		*nn = net_generic(net, nfsd_net_id);