Commit ebf35d8f authored by Chenghai Huang's avatar Chenghai Huang Committed by Herbert Xu
Browse files

crypto: hisilicon/qm - move the barrier before writing to the mailbox register 



Before sending the data via the mailbox to the hardware, to ensure
that the data accessed by the hardware is the most up-to-date,
a write barrier should be added before writing to the mailbox register.
The current memory barrier is placed after writing to the register,
the barrier order should be modified to be before writing to the register.

Signed-off-by: default avatarChenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3d313505

drivers/crypto/hisilicon/qm.c

+5 −1
Original line number Diff line number Diff line
@@ -609,9 +609,13 @@ static void qm_mb_write(struct hisi_qm *qm, const void *src) 
	}



#if IS_ENABLED(CONFIG_ARM64)

	/*

	 * The dmb oshst instruction ensures that the data in the

	 * mailbox is written before it is sent to the hardware.

	 */

	asm volatile("ldp %0, %1, %3\n"

		     "stp %0, %1, %2\n"

		     "dmb oshst\n"

		     "stp %0, %1, %2\n"

		     : "=&r" (tmp0),

		       "=&r" (tmp1),

		       "+Q" (*((char __iomem *)fun_base))