Commit ec0dd36d authored by Tzung-Bi Shih's avatar Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_lightbar: Fix response size initialization 



Commit 1e7913ff ("platform/chrome: cros_ec_lightbar: Reduce
ligthbar get version command") meant to set smaller values for both
request and response sizes.

However, it incorrectly assigned the response size to the `result` field
instead of `insize`.  Fix it.

Reported-by: default avatarGwendal Grignou <gwendal@google.com>
Closes: https://lore.kernel.org/chrome-platform/CAMHSBOVrrYaB=1nEqZk09VkczCrj=6B-P8Fe29TpPdSDgT2CCQ@mail.gmail.com
Fixes: 1e7913ff ("platform/chrome: cros_ec_lightbar: Reduce ligthbar get version command")
Link: https://lore.kernel.org/r/20260130040335.361997-1-tzungbi@kernel.org


Reviewed-by: default avatarGwendal Grignou <gwendal@google.com>
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent a4065662

drivers/platform/chrome/cros_ec_lightbar.c

+1 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ static int get_lightbar_version(struct cros_ec_dev *ec, 
	param = (struct ec_params_lightbar *)msg->data;

	param->cmd = LIGHTBAR_CMD_VERSION;

	msg->outsize = sizeof(param->cmd);

	msg->result = sizeof(resp->version);

	msg->insize = sizeof(resp->version);

	ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);

	if (ret < 0 && ret != -EINVAL) {

		ret = 0;