Commit eca836df authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski
Browse files

soc: samsung: exynos-pmu: Fix uninitialized ret in tensor_set_bits_atomic() 

If tensor_set_bits_atomic() is called with a mask of 0 the function will
just iterate over its bit, not perform any updates and return stack
value of 'ret'.

Also reported by smatch:

  drivers/soc/samsung/exynos-pmu.c:129 tensor_set_bits_atomic() error: uninitialized symbol 'ret'.

Fixes: 0b7c6075 ("soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250104135605.109209-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent 38405d38

drivers/soc/samsung/exynos-pmu.c

+1 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ static int tensor_set_bits_atomic(void *ctx, unsigned int offset, u32 val, 
		if (ret)

			return ret;

	}

	return ret;

	return 0;

}



static bool tensor_is_atomic(unsigned int reg)