Commit ecd942a0 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

devlink: add ACL generic packet traps 



Add packet traps that can report packets that were dropped during ACL
processing.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4a23d45a

Documentation/networking/devlink/devlink-trap.rst

+9 −0
Original line number Diff line number Diff line
@@ -238,6 +238,12 @@ be added to the following table: 
     - ``drop``

     - Traps NVE packets that the device decided to drop because their overlay

       source MAC is multicast

   * - ``ingress_flow_action_drop``

     - ``drop``

     - Traps packets dropped during processing of ingress flow action drop

   * - ``egress_flow_action_drop``

     - ``drop``

     - Traps packets dropped during processing of egress flow action drop



Driver-specific Packet Traps

============================
@@ -277,6 +283,9 @@ narrow. The description of these groups must be added to the following table: 
   * - ``tunnel_drops``

     - Contains packet traps for packets that were dropped by the device during

       tunnel encapsulation / decapsulation

   * - ``acl_drops``

     - Contains packet traps for packets that were dropped by the device during

       ACL processing



Testing

=======

include/net/devlink.h

+9 −0
Original line number Diff line number Diff line
@@ -596,6 +596,8 @@ enum devlink_trap_generic_id { 
	DEVLINK_TRAP_GENERIC_ID_NON_ROUTABLE,

	DEVLINK_TRAP_GENERIC_ID_DECAP_ERROR,

	DEVLINK_TRAP_GENERIC_ID_OVERLAY_SMAC_MC,

	DEVLINK_TRAP_GENERIC_ID_INGRESS_FLOW_ACTION_DROP,

	DEVLINK_TRAP_GENERIC_ID_EGRESS_FLOW_ACTION_DROP,



	/* Add new generic trap IDs above */

	__DEVLINK_TRAP_GENERIC_ID_MAX,
@@ -610,6 +612,7 @@ enum devlink_trap_group_generic_id { 
	DEVLINK_TRAP_GROUP_GENERIC_ID_L3_DROPS,

	DEVLINK_TRAP_GROUP_GENERIC_ID_BUFFER_DROPS,

	DEVLINK_TRAP_GROUP_GENERIC_ID_TUNNEL_DROPS,

	DEVLINK_TRAP_GROUP_GENERIC_ID_ACL_DROPS,



	/* Add new generic trap group IDs above */

	__DEVLINK_TRAP_GROUP_GENERIC_ID_MAX,
@@ -671,6 +674,10 @@ enum devlink_trap_group_generic_id { 
	"decap_error"

#define DEVLINK_TRAP_GENERIC_NAME_OVERLAY_SMAC_MC \

	"overlay_smac_is_mc"

#define DEVLINK_TRAP_GENERIC_NAME_INGRESS_FLOW_ACTION_DROP \

	"ingress_flow_action_drop"

#define DEVLINK_TRAP_GENERIC_NAME_EGRESS_FLOW_ACTION_DROP \

	"egress_flow_action_drop"



#define DEVLINK_TRAP_GROUP_GENERIC_NAME_L2_DROPS \

	"l2_drops"
@@ -680,6 +687,8 @@ enum devlink_trap_group_generic_id { 
	"buffer_drops"

#define DEVLINK_TRAP_GROUP_GENERIC_NAME_TUNNEL_DROPS \

	"tunnel_drops"

#define DEVLINK_TRAP_GROUP_GENERIC_NAME_ACL_DROPS \

	"acl_drops"



#define DEVLINK_TRAP_GENERIC(_type, _init_action, _id, _group, _metadata_cap) \

	{								      \

net/core/devlink.c

+3 −0
Original line number Diff line number Diff line
@@ -7795,6 +7795,8 @@ static const struct devlink_trap devlink_trap_generic[] = { 
	DEVLINK_TRAP(NON_ROUTABLE, DROP),

	DEVLINK_TRAP(DECAP_ERROR, EXCEPTION),

	DEVLINK_TRAP(OVERLAY_SMAC_MC, DROP),

	DEVLINK_TRAP(INGRESS_FLOW_ACTION_DROP, DROP),

	DEVLINK_TRAP(EGRESS_FLOW_ACTION_DROP, DROP),

};



#define DEVLINK_TRAP_GROUP(_id)						      \
@@ -7808,6 +7810,7 @@ static const struct devlink_trap_group devlink_trap_group_generic[] = { 
	DEVLINK_TRAP_GROUP(L3_DROPS),

	DEVLINK_TRAP_GROUP(BUFFER_DROPS),

	DEVLINK_TRAP_GROUP(TUNNEL_DROPS),

	DEVLINK_TRAP_GROUP(ACL_DROPS),

};



static int devlink_trap_generic_verify(const struct devlink_trap *trap)