Unverified Commit ed4d5ab1 authored by Chun-Kuang Hu's avatar Chun-Kuang Hu Committed by AngeloGioacchino Del Regno
Browse files

soc: mediatek: cmdq: Fix typo of CMDQ_JUMP_RELATIVE 



For cmdq jump command, offset 0 means relative jump and offset 1
means absolute jump. cmdq_pkt_jump() is absolute jump, so fix the
typo of CMDQ_JUMP_RELATIVE in cmdq_pkt_jump().

Fixes: 946f1792 ("soc: mediatek: cmdq: add jump function")
Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240222154120.16959-2-chunkuang.hu@kernel.org


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 4cece764

drivers/soc/mediatek/mtk-cmdq-helper.c

+3 −2
Original line number Diff line number Diff line
@@ -14,7 +14,8 @@ 
#define CMDQ_POLL_ENABLE_MASK	BIT(0)

#define CMDQ_EOC_IRQ_EN		BIT(0)

#define CMDQ_REG_TYPE		1

#define CMDQ_JUMP_RELATIVE	1

#define CMDQ_JUMP_RELATIVE	0

#define CMDQ_JUMP_ABSOLUTE	1



struct cmdq_instruction {

	union {
@@ -397,7 +398,7 @@ int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr) 
	struct cmdq_instruction inst = {};



	inst.op = CMDQ_CODE_JUMP;

	inst.offset = CMDQ_JUMP_RELATIVE;

	inst.offset = CMDQ_JUMP_ABSOLUTE;

	inst.value = addr >>

		cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan);

	return cmdq_pkt_append_command(pkt, inst);