Commit edb888d2 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

emulex/benet: correct command version selection in be_cmd_get_stats() 



Logic here always sets hdr->version to 2 if it is not a BE3 or Lancer chip,
even if it is BE2. Use 'else if' to prevent multiple assignments, setting
version 0 for BE2, version 1 for BE3 and Lancer, and version 2 for others.
Fixes potential incorrect version setting when BE2_chip and
BE3_chip/lancer_chip checks could both be true.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250519141731.691136-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 220a29d0

drivers/net/ethernet/emulex/benet/be_cmds.c

+1 −1
Original line number Diff line number Diff line
@@ -1609,7 +1609,7 @@ int be_cmd_get_stats(struct be_adapter *adapter, struct be_dma_mem *nonemb_cmd) 
	/* version 1 of the cmd is not supported only by BE2 */

	if (BE2_chip(adapter))

		hdr->version = 0;

	if (BE3_chip(adapter) || lancer_chip(adapter))

	else if (BE3_chip(adapter) || lancer_chip(adapter))

		hdr->version = 1;

	else

		hdr->version = 2;