Commit effe6d27 authored by Li Zhijian's avatar Li Zhijian Committed by Thomas Gleixner
Browse files

kernel/cpu: Convert snprintf() to sysfs_emit() 



Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

No functional change intended.

Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240116045151.3940401-40-lizhijian@fujitsu.com
parent ef7e585b

kernel/cpu.c

+2 −2
Original line number Diff line number Diff line
@@ -3004,7 +3004,7 @@ static ssize_t control_show(struct device *dev, 
		return sysfs_emit(buf, "%d\n", cpu_smt_num_threads);

#endif



	return snprintf(buf, PAGE_SIZE - 2, "%s\n", state);

	return sysfs_emit(buf, "%s\n", state);

}



static ssize_t control_store(struct device *dev, struct device_attribute *attr,
@@ -3017,7 +3017,7 @@ static DEVICE_ATTR_RW(control); 
static ssize_t active_show(struct device *dev,

			   struct device_attribute *attr, char *buf)

{

	return snprintf(buf, PAGE_SIZE - 2, "%d\n", sched_smt_active());

	return sysfs_emit(buf, "%d\n", sched_smt_active());

}

static DEVICE_ATTR_RO(active);