Commit f0265203 authored by Rodrigo Vivi's avatar Rodrigo Vivi
Browse files

drm/xe: Only set PCI d3cold_allowed when we are really allowing. 



First of all it was strange to see:
if (allowed) {
...
} else {
   D3COLD_ENABLE
}

But besides this misalignment, let's also use the pci
d3cold_allowed useful to us and know that we are not really
allowing d3cold.

Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: default avatarAnshuman Gupta <anshuman.gupta@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 8f3013e0

drivers/gpu/drm/xe/xe_pci.c

+1 −2
Original line number Diff line number Diff line
@@ -766,6 +766,7 @@ static int xe_pci_runtime_suspend(struct device *dev) 
	pci_save_state(pdev);



	if (xe->d3cold.allowed) {

		d3cold_toggle(pdev, D3COLD_ENABLE);

		pci_disable_device(pdev);

		pci_ignore_hotplug(pdev);

		pci_set_power_state(pdev, PCI_D3cold);
@@ -795,8 +796,6 @@ static int xe_pci_runtime_resume(struct device *dev) 
			return err;



		pci_set_master(pdev);

	} else {

		d3cold_toggle(pdev, D3COLD_ENABLE);

	}



	return xe_pm_runtime_resume(xe);