Unverified Commit f077638b authored by Christian Brauner's avatar Christian Brauner
Browse files

pidfs: fix pidfs_free_pid() 



Ensure that we handle the case where task creation fails and pid->attr
was never accessed at all.

Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 4e3d1e6e

fs/pidfs.c

+10 −8
Original line number Diff line number Diff line
@@ -150,18 +150,20 @@ void pidfs_free_pid(struct pid *pid) 
	 */

	VFS_WARN_ON_ONCE(pid->stashed);



	if (IS_ERR(attr))

		return;



	/*

	 * Any dentry must've been wiped from the pid by now. Otherwise

	 * there's a reference count bug.

	 * This if an error occurred during e.g., task creation that

	 * causes us to never go through the exit path.

	 */

	VFS_WARN_ON_ONCE(pid->stashed);

	if (unlikely(!attr))

		return;



	/* This never had a pidfd created. */

	if (IS_ERR(attr))

		return;



	xattrs = attr->xattrs;

	xattrs = no_free_ptr(attr->xattrs);

	if (xattrs)

		simple_xattrs_free(attr->xattrs, NULL);

		simple_xattrs_free(xattrs, NULL);

}



#ifdef CONFIG_PROC_FS