Commit f1013d84 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Michal Simek
Browse files

soc/xilinx: zynqmp_power: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230925095532.1984344-41-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMichal Simek <michal.simek@amd.com>
parent b85ea95d

drivers/soc/xilinx/zynqmp_power.c

+2 −4
Original line number Diff line number Diff line
@@ -275,7 +275,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev) 
	return 0;

}



static int zynqmp_pm_remove(struct platform_device *pdev)

static void zynqmp_pm_remove(struct platform_device *pdev)

{

	sysfs_remove_file(&pdev->dev.kobj, &dev_attr_suspend_mode.attr);

	if (event_registered)
@@ -283,8 +283,6 @@ static int zynqmp_pm_remove(struct platform_device *pdev) 


	if (!rx_chan)

		mbox_free_channel(rx_chan);



	return 0;

}



static const struct of_device_id pm_of_match[] = {
@@ -295,7 +293,7 @@ MODULE_DEVICE_TABLE(of, pm_of_match); 


static struct platform_driver zynqmp_pm_platform_driver = {

	.probe = zynqmp_pm_probe,

	.remove = zynqmp_pm_remove,

	.remove_new = zynqmp_pm_remove,

	.driver = {

		.name = "zynqmp_power",

		.of_match_table = pm_of_match,