Commit f1234301 authored by Liao Yuanhong's avatar Liao Yuanhong Committed by Jason Gunthorpe
Browse files

pds_fwctl: Remove the use of dev_err_probe() 

Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Link: https://patch.msgid.link/r/20250820124011.474224-1-liaoyuanhong@vivo.com


Signed-off-by: default avatarLiao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarJonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: default avatarBrett Creeley <brett.creeley@amd.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 7f059e47

drivers/fwctl/pds/main.c

+1 −1
Original line number Diff line number Diff line
@@ -481,7 +481,7 @@ static int pdsfc_probe(struct auxiliary_device *adev, 
	pdsfc = fwctl_alloc_device(&padev->vf_pdev->dev, &pdsfc_ops,

				   struct pdsfc_dev, fwctl);

	if (!pdsfc)

		return dev_err_probe(dev, -ENOMEM, "Failed to allocate fwctl device struct\n");

		return -ENOMEM;

	pdsfc->padev = padev;



	err = pdsfc_identify(pdsfc);