Unverified Commit f1c66826 authored by Marco Crivellari's avatar Marco Crivellari Committed by Mark Brown
Browse files

regulator: qcomm-labibb: replace use of system_wq with system_dfl_wq 



Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6 ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea5 ("workqueue: Add new WQ_PERCPU flag")

This specific workload do not benefit from a per-cpu workqueue, so use
the default unbound workqueue (system_dfl_wq) instead.

Suggested-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarMarco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251106145003.245866-1-marco.crivellari@suse.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c22f7a5c

drivers/regulator/qcom-labibb-regulator.c

+2 −2
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ static void qcom_labibb_ocp_recovery_worker(struct work_struct *work) 
	return;



reschedule:

	mod_delayed_work(system_wq, &vreg->ocp_recovery_work,

	mod_delayed_work(system_dfl_wq, &vreg->ocp_recovery_work,

			 msecs_to_jiffies(OCP_RECOVERY_INTERVAL_MS));

}
@@ -510,7 +510,7 @@ static void qcom_labibb_sc_recovery_worker(struct work_struct *work) 
	 * taking action is not truly urgent anymore.

	 */

	vreg->sc_count++;

	mod_delayed_work(system_wq, &vreg->sc_recovery_work,

	mod_delayed_work(system_dfl_wq, &vreg->sc_recovery_work,

			 msecs_to_jiffies(SC_RECOVERY_INTERVAL_MS));

}