Commit f2aac4c7 authored by Niklas Cassel's avatar Niklas Cassel
Browse files

ata: libata-core: Add ATA_QUIRK_NO_LPM_ON_ATI for certain Samsung SSDs 



Before commit 7627a0ed ("ata: ahci: Drop low power policy board type")
the ATI AHCI controllers specified board type 'board_ahci' rather than
board type 'board_ahci'. This means that LPM was historically not enabled
for the ATI AHCI controllers.

By looking at commit 7a8526a5 ("libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI
for Samsung 860 and 870 SSD."), it is clear that, for some unknown reason,
that Samsung SSDs do not play nice with ATI AHCI controllers. (When using
other AHCI controllers, NCQ can be enabled on these Samsung SSDs without
issues.)

In a similar way, from user reports, it is clear the ATI AHCI controllers
can enable LPM on e.g. Maxtor HDDs perfectly fine, but when enabling LPM
on certain Samsung SSDs, things break. (E.g. the SSDs will not get detected
by the ATI AHCI controller even after a COMRESET.)

Yet, when using LPM on these Samsung SSDs with other AHCI controllers, e.g.
Intel AHCI controllers, these Samsung drives appear to work perfectly fine.

Considering that the combination of ATI + Samsung, for some unknown reason,
does not seem to work well, disable LPM when detecting an ATI AHCI
controller with a problematic Samsung SSD.

Apply this new ATA_QUIRK_NO_LPM_ON_ATI quirk for all Samsung SSDs that have
already been reported to not play nice with ATI (ATA_QUIRK_NO_NCQ_ON_ATI).

Fixes: 7627a0ed ("ata: ahci: Drop low power policy board type")
Suggested-by: default avatarHans de Goede <hdegoede@redhat.com>
Reported-by: default avatarEric <eric.4.debian@grabatoulnz.fr>
Closes: https://lore.kernel.org/linux-ide/Z8SBZMBjvVXA7OAK@eldamar.lan/


Tested-by: default avatarEric <eric.4.debian@grabatoulnz.fr>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250317170348.1748671-2-cassel@kernel.org


Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
parent a2f925a2

drivers/ata/libata-core.c

+11 −3
Original line number Diff line number Diff line
@@ -2845,6 +2845,10 @@ int ata_dev_configure(struct ata_device *dev) 
	    (id[ATA_ID_SATA_CAPABILITY] & 0xe) == 0x2)

		dev->quirks |= ATA_QUIRK_NOLPM;



	if (dev->quirks & ATA_QUIRK_NO_LPM_ON_ATI &&

	    ata_dev_check_adapter(dev, PCI_VENDOR_ID_ATI))

		dev->quirks |= ATA_QUIRK_NOLPM;



	if (ap->flags & ATA_FLAG_NO_LPM)

		dev->quirks |= ATA_QUIRK_NOLPM;
@@ -3897,6 +3901,7 @@ static const char * const ata_quirk_names[] = { 
	[__ATA_QUIRK_MAX_SEC_1024]	= "maxsec1024",

	[__ATA_QUIRK_MAX_TRIM_128M]	= "maxtrim128m",

	[__ATA_QUIRK_NO_NCQ_ON_ATI]	= "noncqonati",

	[__ATA_QUIRK_NO_LPM_ON_ATI]	= "nolpmonati",

	[__ATA_QUIRK_NO_ID_DEV_LOG]	= "noiddevlog",

	[__ATA_QUIRK_NO_LOG_DIR]	= "nologdir",

	[__ATA_QUIRK_NO_FUA]		= "nofua",
@@ -4142,13 +4147,16 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = { 
						ATA_QUIRK_ZERO_AFTER_TRIM },

	{ "Samsung SSD 860*",		NULL,	ATA_QUIRK_NO_NCQ_TRIM |

						ATA_QUIRK_ZERO_AFTER_TRIM |

						ATA_QUIRK_NO_NCQ_ON_ATI },

						ATA_QUIRK_NO_NCQ_ON_ATI |

						ATA_QUIRK_NO_LPM_ON_ATI },

	{ "Samsung SSD 870*",		NULL,	ATA_QUIRK_NO_NCQ_TRIM |

						ATA_QUIRK_ZERO_AFTER_TRIM |

						ATA_QUIRK_NO_NCQ_ON_ATI },

						ATA_QUIRK_NO_NCQ_ON_ATI |

						ATA_QUIRK_NO_LPM_ON_ATI },

	{ "SAMSUNG*MZ7LH*",		NULL,	ATA_QUIRK_NO_NCQ_TRIM |

						ATA_QUIRK_ZERO_AFTER_TRIM |

						ATA_QUIRK_NO_NCQ_ON_ATI, },

						ATA_QUIRK_NO_NCQ_ON_ATI |

						ATA_QUIRK_NO_LPM_ON_ATI },

	{ "FCCT*M500*",			NULL,	ATA_QUIRK_NO_NCQ_TRIM |

						ATA_QUIRK_ZERO_AFTER_TRIM },

include/linux/libata.h

+2 −0
Original line number Diff line number Diff line
@@ -88,6 +88,7 @@ enum ata_quirks { 
	__ATA_QUIRK_MAX_SEC_1024,	/* Limit max sects to 1024 */

	__ATA_QUIRK_MAX_TRIM_128M,	/* Limit max trim size to 128M */

	__ATA_QUIRK_NO_NCQ_ON_ATI,	/* Disable NCQ on ATI chipset */

	__ATA_QUIRK_NO_LPM_ON_ATI,	/* Disable LPM on ATI chipset */

	__ATA_QUIRK_NO_ID_DEV_LOG,	/* Identify device log missing */

	__ATA_QUIRK_NO_LOG_DIR,		/* Do not read log directory */

	__ATA_QUIRK_NO_FUA,		/* Do not use FUA */
@@ -432,6 +433,7 @@ enum { 
	ATA_QUIRK_MAX_SEC_1024		= (1U << __ATA_QUIRK_MAX_SEC_1024),

	ATA_QUIRK_MAX_TRIM_128M		= (1U << __ATA_QUIRK_MAX_TRIM_128M),

	ATA_QUIRK_NO_NCQ_ON_ATI		= (1U << __ATA_QUIRK_NO_NCQ_ON_ATI),

	ATA_QUIRK_NO_LPM_ON_ATI		= (1U << __ATA_QUIRK_NO_LPM_ON_ATI),

	ATA_QUIRK_NO_ID_DEV_LOG		= (1U << __ATA_QUIRK_NO_ID_DEV_LOG),

	ATA_QUIRK_NO_LOG_DIR		= (1U << __ATA_QUIRK_NO_LOG_DIR),

	ATA_QUIRK_NO_FUA		= (1U << __ATA_QUIRK_NO_FUA),