Commit f2c5c210 authored by Rik van Riel's avatar Rik van Riel Committed by Ingo Molnar
Browse files

x86/mm: Remove pv_ops.mmu.tlb_remove_table call 



Every pv_ops.mmu.tlb_remove_table call ends up calling tlb_remove_table.

Get rid of the indirection by simply calling tlb_remove_table directly,
and not going through the paravirt function pointers.

Suggested-by: default avatarQi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: default avatarRik van Riel <riel@surriel.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarManali Shukla <Manali.Shukla@amd.com>
Tested-by: default avatarBrendan Jackman <jackmanb@google.com>
Tested-by: default avatarMichael Kelley <mhklinux@outlook.com>
Link: https://lore.kernel.org/r/20250213161423.449435-3-riel@surriel.com
parent a3725973

arch/x86/hyperv/mmu.c

+0 −1
Original line number Diff line number Diff line
@@ -239,5 +239,4 @@ void hyperv_setup_mmu_ops(void) 


	pr_info("Using hypercall for remote TLB flush\n");

	pv_ops.mmu.flush_tlb_multi = hyperv_flush_tlb_multi;

	pv_ops.mmu.tlb_remove_table = tlb_remove_table;

}

arch/x86/include/asm/paravirt.h

+0 −5
Original line number Diff line number Diff line
@@ -91,11 +91,6 @@ static inline void __flush_tlb_multi(const struct cpumask *cpumask, 
	PVOP_VCALL2(mmu.flush_tlb_multi, cpumask, info);

}



static inline void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table)

{

	PVOP_VCALL2(mmu.tlb_remove_table, tlb, table);

}



static inline void paravirt_arch_exit_mmap(struct mm_struct *mm)

{

	PVOP_VCALL1(mmu.exit_mmap, mm);

arch/x86/include/asm/paravirt_types.h

+0 −2
Original line number Diff line number Diff line
@@ -134,8 +134,6 @@ struct pv_mmu_ops { 
	void (*flush_tlb_multi)(const struct cpumask *cpus,

				const struct flush_tlb_info *info);



	void (*tlb_remove_table)(struct mmu_gather *tlb, void *table);



	/* Hook for intercepting the destruction of an mm_struct. */

	void (*exit_mmap)(struct mm_struct *mm);

	void (*notify_page_enc_status_changed)(unsigned long pfn, int npages, bool enc);

arch/x86/kernel/kvm.c

+0 −1
Original line number Diff line number Diff line
@@ -838,7 +838,6 @@ static void __init kvm_guest_init(void) 
#ifdef CONFIG_SMP

	if (pv_tlb_flush_supported()) {

		pv_ops.mmu.flush_tlb_multi = kvm_flush_tlb_multi;

		pv_ops.mmu.tlb_remove_table = tlb_remove_table;

		pr_info("KVM setup pv remote TLB flush\n");

	}

arch/x86/kernel/paravirt.c

+0 −1
Original line number Diff line number Diff line
@@ -180,7 +180,6 @@ struct paravirt_patch_template pv_ops = { 
	.mmu.flush_tlb_kernel	= native_flush_tlb_global,

	.mmu.flush_tlb_one_user	= native_flush_tlb_one_user,

	.mmu.flush_tlb_multi	= native_flush_tlb_multi,

	.mmu.tlb_remove_table	= tlb_remove_table,



	.mmu.exit_mmap		= paravirt_nop,

	.mmu.notify_page_enc_status_changed	= paravirt_nop,